Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: pkg/dev_compiler/lib/src/compiler/command.dart

Issue 2836483002: Snapshot DDC trained on itself (Closed)
Patch Set: Test/fix for windows Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/lib/src/compiler/command.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/command.dart b/pkg/dev_compiler/lib/src/compiler/command.dart
index 6170f6d85f7631e774f687cf7086b235ba7bd109..d037eac28ca296ae92375b42c4ed6f68a3e46f24 100644
--- a/pkg/dev_compiler/lib/src/compiler/command.dart
+++ b/pkg/dev_compiler/lib/src/compiler/command.dart
@@ -161,14 +161,14 @@ void _compile(ArgResults argResults, AnalyzerOptions analyzerOptions,
var libraryRoot = argResults['library-root'] as String;
if (libraryRoot != null) {
- libraryRoot = path.absolute(libraryRoot);
+ libraryRoot = path.canonicalize(libraryRoot);
} else {
libraryRoot = Directory.current.path;
}
var moduleRoot = argResults['module-root'] as String;
String modulePath;
if (moduleRoot != null) {
- moduleRoot = path.absolute(moduleRoot);
+ moduleRoot = path.canonicalize(moduleRoot);
if (!path.isWithin(moduleRoot, firstOutPath)) {
_usageException('Output file $firstOutPath must be within the module '
'root directory $moduleRoot');

Powered by Google App Engine
This is Rietveld 408576698