Snapshot DDC trained on itself

Snapshot DDC trained on itself

Note: path.canonicalize appears to normalize windows paths (c:/ vs c:\).

Fixes #29119

R=jmesserly@google.com, rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/75b7bea014d832d2ae7f4c106b6d7a6aa7ab27e2

[vsm, 2017-04-21 17:05:52]

Description was changed from

==========
Snapshot DDC trained on itself

BUG=
==========

to

==========
Snapshot DDC trained on itself

Note: path.canonicalize appears to normalize windows paths (c:/ vs c:\).
==========

[vsm, 2017-04-21 17:05:52]

vsm@google.com changed reviewers:
+ jmesserly@google.com, rnystrom@google.com

[Jennifer Messerly, 2017-04-21 17:19:18]

Oh but isn't --help supposed to be our fastest command??? ;)

j/k. LGTM!

[vsm, 2017-04-21 17:21:53]

Description was changed from

==========
Snapshot DDC trained on itself

Note: path.canonicalize appears to normalize windows paths (c:/ vs c:\).
==========

to

==========
Snapshot DDC trained on itself

Note: path.canonicalize appears to normalize windows paths (c:/ vs c:\).

Fixes #29119
==========

[Bob Nystrom, 2017-04-21 22:43:41]

lgtm

https://codereview.chromium.org/2836483002/diff/40001/utils/dartdevc/BUILD.gn
File utils/dartdevc/BUILD.gn (right):

https://codereview.chromium.org/2836483002/diff/40001/utils/dartdevc/BUILD.gn...
utils/dartdevc/BUILD.gn:22: rebase_path("//pkg/dev_compiler/bin") ],
I like the way absolute paths in GN files look too, but Zach says we shouldn't
use them since some projects (Turquoise?) may use the same GN files with a
different root directory.

[vsm, 2017-04-21 23:20:18]

Description was changed from

==========
Snapshot DDC trained on itself

Note: path.canonicalize appears to normalize windows paths (c:/ vs c:\).

Fixes #29119
==========

to

==========
Snapshot DDC trained on itself

Note: path.canonicalize appears to normalize windows paths (c:/ vs c:\).

Fixes #29119

R=jmesserly@google.com, rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/75b7bea014d832d2ae7f4c106b6d7a6aa7ab27e2
==========

[vsm, 2017-04-21 23:20:19]

Committed patchset #4 (id:60001) manually as
75b7bea014d832d2ae7f4c106b6d7a6aa7ab27e2 (presubmit successful).

[vsm, 2017-04-21 23:20:32]

https://codereview.chromium.org/2836483002/diff/40001/utils/dartdevc/BUILD.gn
File utils/dartdevc/BUILD.gn (right):

https://codereview.chromium.org/2836483002/diff/40001/utils/dartdevc/BUILD.gn...
utils/dartdevc/BUILD.gn:22: rebase_path("//pkg/dev_compiler/bin") ],
On 2017/04/21 22:43:41, Bob Nystrom wrote:
> I like the way absolute paths in GN files look too, but Zach says we shouldn't
> use them since some projects (Turquoise?) may use the same GN files with a
> different root directory.

Done.

[rmacnak, 2017-04-24 16:56:28]

On 2017/04/21 23:20:32, vsm wrote:
> https://codereview.chromium.org/2836483002/diff/40001/utils/dartdevc/BUILD.gn
> File utils/dartdevc/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2836483002/diff/40001/utils/dartdevc/BUILD.gn...
> utils/dartdevc/BUILD.gn:22: rebase_path("//pkg/dev_compiler/bin") ],
> On 2017/04/21 22:43:41, Bob Nystrom wrote:
> > I like the way absolute paths in GN files look too, but Zach says we
shouldn't
> > use them since some projects (Turquoise?) may use the same GN files with a
> > different root directory.
> 
> Done.

Cool!

[vsm, 2017-04-24 17:03:16]

On 2017/04/24 16:56:28, rmacnak wrote:
> On 2017/04/21 23:20:32, vsm wrote:
> >
https://codereview.chromium.org/2836483002/diff/40001/utils/dartdevc/BUILD.gn
> > File utils/dartdevc/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/2836483002/diff/40001/utils/dartdevc/BUILD.gn...
> > utils/dartdevc/BUILD.gn:22: rebase_path("//pkg/dev_compiler/bin") ],
> > On 2017/04/21 22:43:41, Bob Nystrom wrote:
> > > I like the way absolute paths in GN files look too, but Zach says we
> shouldn't
> > > use them since some projects (Turquoise?) may use the same GN files with a
> > > different root directory.
> > 
> > Done.
> 
> Cool!

It's much faster from the command line!  :-)