Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4709)

Unified Diff: chrome/browser/ui/webui/chromeos/login/network_state_informer.cc

Issue 2836453003: tray: Show warning in network tray when VPN or proxy used. (Closed)
Patch Set: Fixed patch set 3 errors. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/network/network_list.cc ('k') | chromeos/network/proxy/ui_proxy_config_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/network_state_informer.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc b/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc
index 3b3c24ea701a15e5d9df715612859699b21fa5be..bf7af7ca047a7800a9239e9b8b21258185710521 100644
--- a/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc
+++ b/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc
@@ -14,6 +14,7 @@
#include "chromeos/network/network_state.h"
#include "chromeos/network/network_state_handler.h"
#include "chromeos/network/proxy/proxy_config_handler.h"
+#include "chromeos/network/proxy/ui_proxy_config_service.h"
#include "components/proxy_config/proxy_config_dictionary.h"
#include "components/proxy_config/proxy_prefs.h"
#include "net/proxy/proxy_config.h"
@@ -29,20 +30,6 @@ const char kNetworkStateCaptivePortal[] = "behind captive portal";
const char kNetworkStateConnecting[] = "connecting";
const char kNetworkStateProxyAuthRequired[] = "proxy auth required";
-bool HasDefaultNetworkProxyConfigured() {
- const NetworkState* network =
- NetworkHandler::Get()->network_state_handler()->DefaultNetwork();
- if (!network)
- return false;
- onc::ONCSource onc_source = onc::ONC_SOURCE_NONE;
- std::unique_ptr<ProxyConfigDictionary> proxy_dict =
- proxy_config::GetProxyConfigForNetwork(
- NULL, g_browser_process->local_state(), *network, &onc_source);
- ProxyPrefs::ProxyMode mode;
- return (proxy_dict && proxy_dict->GetMode(&mode) &&
- mode == ProxyPrefs::MODE_FIXED_SERVERS);
-}
-
NetworkStateInformer::State GetStateForDefaultNetwork() {
const NetworkState* network =
NetworkHandler::Get()->network_state_handler()->DefaultNetwork();
@@ -62,13 +49,17 @@ NetworkStateInformer::State GetStateForDefaultNetwork() {
// NetworkPortalDetector's state of current network is unknown.
if (status == NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_ONLINE ||
(status == NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_UNKNOWN &&
- !HasDefaultNetworkProxyConfigured() &&
+ !NetworkHandler::Get()
+ ->ui_proxy_config_service()
+ ->HasDefaultNetworkProxyConfigured() &&
network->connection_state() == shill::kStateOnline)) {
return NetworkStateInformer::ONLINE;
}
if (status ==
NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_PROXY_AUTH_REQUIRED &&
- HasDefaultNetworkProxyConfigured()) {
+ NetworkHandler::Get()
+ ->ui_proxy_config_service()
+ ->HasDefaultNetworkProxyConfigured()) {
return NetworkStateInformer::PROXY_AUTH_REQUIRED;
}
if (status == NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_PORTAL ||
« no previous file with comments | « ash/system/network/network_list.cc ('k') | chromeos/network/proxy/ui_proxy_config_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698