components/payments/mojom/payment_request.mojom - Issue 2836443002: No rate limit for canMakePayment() on localhost and file://.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/payments/mojom/payment_request.mojom

Issue 2836443002: No rate limit for canMakePayment() on localhost and file://. (Closed)

Patch Set: Comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/payments/mojom/payment_request.mojom

diff --git a/components/payments/mojom/payment_request.mojom b/components/payments/mojom/payment_request.mojom

index 600838286adf210199a922a77ae0151e83c2dcf3..99dfa91ba9c86b8b4a0ae8818f5124dd63251f31 100644

--- a/components/payments/mojom/payment_request.mojom

+++ b/components/payments/mojom/payment_request.mojom

@@ -80,7 +80,12 @@ enum PaymentErrorReason {

enum CanMakePaymentQueryResult {

CAN_MAKE_PAYMENT,

CANNOT_MAKE_PAYMENT,

- QUERY_QUOTA_EXCEEDED

+ QUERY_QUOTA_EXCEEDED,

+ // Used only on localhost and file:// schemes to warn web developer that the

+ // query quota has exceeded, but Chrome is returning an answer anyway.

+ WARNING_CAN_MAKE_PAYMENT,

+ WARNING_CANNOT_MAKE_PAYMENT,

};

interface PaymentRequestClient {