Move testEvictedTabReloadFailure to an external URL egtest target.

ios/chrome/browser/metrics/BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 source_set("metrics") {
   configs += [ "//build/config/compiler:enable_arc" ]
   sources = [
     "field_trial_synchronizer.cc",
     "field_trial_synchronizer.h",
     "ios_chrome_metrics_service_accessor.cc",
@@ skipping 139 matching lines @@
 }
 
 source_set("eg_tests") {
   configs += [ "//build/config/compiler:enable_arc" ]
   testonly = true
   sources = [
     "tab_usage_recorder_egtest.mm",
   ]
   deps = [
     ":metrics_internal",
+    ":test_support",
     "//base",
     "//base/test:test_support",
     "//components/strings",
-    "//ios/chrome/app/strings",
-    "//ios/chrome/browser",
     "//ios/chrome/browser/ui",
     "//ios/chrome/browser/ui/settings",
     "//ios/chrome/browser/ui/toolbar",
     "//ios/chrome/browser/ui/tools_menu",
     "//ios/chrome/test/app:test_support",
     "//ios/chrome/test/earl_grey:test_support",
     "//ios/testing:ios_test_support",
-    "//ios/third_party/earl_grey",
     "//ios/web:earl_grey_test_support",
     "//ios/web:test_support",
     "//ui/base",
+    "//url",
   ]
   libs = [ "XCTest.framework" ]
 }
+
+# These tests use external URLs and hit network.  They will fail if the network
+# is unavailable. Reference to crbug.com/694662.

[baxley, 2017/05/01 23:20:06]

Is the bug reference necessary? If it is, should it be a TODO?

When this is fixed, will the bug number still be useful in the comment?

[lpromero, 2017/05/02 13:56:01]

When crbug.com/694662 is fixed, these tests won't rely on network anymore, and
could be folded back to the main EG target. I'll update the comment.

+source_set("external_url_eg_tests") {

[baxley, 2017/05/01 23:20:06]

Is there enough in common that it's worth creating test_support for the
intersection between the external URL and hermetic tests? Or are they unique
enough (or this will be removed at some point) that it's better to do it this
way?

Just a question, I trust your judgement, so if you feel one way you don't need
to wait for me.

[lpromero, 2017/05/02 13:56:01]

Personally, I think we could remove this external_url_eg_tests target once the
underlying bug (crbug.com/694662) is fixed.
Below, I created a test_support that is the intersection between the external
URL and hermetic tests. Did you envision something broader than tab usage
recorder tests?

[baxley, 2017/05/02 14:18:46]

No, I meant just for the tab usage recorder tests. I think it's good how you
have it. Especially if these won't live forever.

+  configs += [ "//build/config/compiler:enable_arc" ]
+  testonly = true
+  sources = [
+    "external_url_tab_usage_recorder_egtest.mm",
+  ]
+  deps = [
+    ":metrics_internal",
+    ":test_support",
+    "//ios/chrome/test/app:test_support",
+    "//ios/chrome/test/earl_grey:test_support",
+    "//ios/web:test_support",
+  ]
+  libs = [ "XCTest.framework" ]
+}
+
+source_set("test_support") {
+  testonly = true
+  sources = [
+    "tab_usage_recorder_test_util.h",
+    "tab_usage_recorder_test_util.mm",
+  ]
+  deps = [
+    "//base",
+    "//ios/chrome/app/strings",
+    "//ios/chrome/browser/ui",
+    "//ios/chrome/browser/ui/tools_menu",
+    "//ios/chrome/test/app:test_support",
+    "//ios/chrome/test/earl_grey:test_support",
+    "//ios/testing:ios_test_support",
+    "//ui/base",
+  ]
+  configs += [ "//build/config/compiler:enable_arc" ]
+}