Issue 283633002: Mojo: Tighten up mojo/embedder/DEPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 283633002: Mojo: Tighten up mojo/embedder/DEPS. (Closed)

Created:
6 years, 7 months ago by viettrungluu

Modified:
6 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Tighten up mojo/embedder/DEPS. Don't allow .h files in mojo/embedder to include files from mojo/system (except for system_impl_export.h). R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269921

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	mojo/embedder/DEPS	View		1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/283633002/1

6 years, 7 months ago (2014-05-12 22:13:06 UTC) #4

viettrungluu

6 years, 7 months ago (2014-05-12 23:56:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r269921 (presubmit successful).

Expand Messages | Collapse Messages