Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2836323002: Add more factory methods to FrontEndStrategy. (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add more factory methods to FrontEndStrategy. This prepares for running closed_world2_test through the normal Compiler pipeline. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b8627544ba8c925c7f669afbf1b2779ecbd7dfb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -129 lines) Patch
M pkg/compiler/lib/src/frontend_strategy.dart View 2 chunks +41 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 6 chunks +14 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_data.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 2 chunks +162 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 3 chunks +48 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 6 chunks +7 lines, -108 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-04-25 14:55:08 UTC) #2
Siggi Cherem (dart-lang)
lgtm - this answers my question from the other CL :)
3 years, 7 months ago (2017-04-25 20:02:53 UTC) #3
Johnni Winther
3 years, 7 months ago (2017-04-26 07:56:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b8627544ba8c925c7f669afbf1b2779ecbd7dfb8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698