Issue 28363002: [OTS] Fix "continue-stream" handling in the woff2 decoder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28363002: [OTS] Fix "continue-stream" handling in the woff2 decoder (Closed)

Created:
7 years, 2 months ago by Kunihiko Sakamoto

Modified:
7 years, 2 months ago

Reviewers:
Yusuke Sato

CC:
chromium-reviews, szabadka_google.com

Base URL:
http://ots.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

[OTS] Fix "continue-stream" handling in the woff2 decoder (1) When reading the short form of the directory, set the compressed length to zero for tables with the continue-stream flag set. (2) Initialize transform_buf outside the main loop since it is re-used for continue-streams. Patch contributed by Zoltan Szabadka (szabadka@google.com) R=yusukes@chromium.org Committed: 104

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/woff2.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kunihiko Sakamoto

7 years, 2 months ago (2013-10-24 03:29:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r104 (presubmit successful).

Expand Messages | Collapse Messages