Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: media/base/audio_renderer_sink.h

Issue 2836293002: Introduce AudioRendererSink::IsOptimizedForHardwareParameters (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/audio_renderer_sink.h
diff --git a/media/base/audio_renderer_sink.h b/media/base/audio_renderer_sink.h
index 4052112bab555b6703c90962422323f5cbeff0e4..90c68daae8e750e96ae50e94bc7825265319cc6e 100644
--- a/media/base/audio_renderer_sink.h
+++ b/media/base/audio_renderer_sink.h
@@ -71,7 +71,8 @@ class AudioRendererSink
// If the sink is not associated with any output device, |device_status| of
// OutputDeviceInfo should be set to OUTPUT_DEVICE_STATUS_ERROR_INTERNAL.
// Must never be called on the IO thread.
- virtual OutputDeviceInfo GetOutputDeviceInfo() = 0;
+ virtual OutputDeviceInfo GetOutputDeviceInfo(
+ const AudioParameters& preferred_params = AudioParameters()) = 0;
o1ka 2017/04/26 14:27:54 I understand why you are doing this for https://co
flim-chromium 2017/04/26 16:24:09 |preferred_params| would be the native parameters
o1ka 2017/04/26 17:40:29 This does not quite make sense to me in the contex
DaleCurtis 2017/04/26 18:25:59 That should be okay, we'll just end using the brow
// If DCHECKs are enabled, this function returns true if called on rendering
// thread, otherwise false. With DCHECKs disabled, it returns true. Thus, it

Powered by Google App Engine
This is Rietveld 408576698