Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: chromecast/media/service/cast_mojo_media_client.cc

Issue 2836293002: Introduce AudioRendererSink::IsOptimizedForHardwareParameters (Closed)
Patch Set: revert preferred_params and add OptimizedForHardwareParameters Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | media/audio/audio_output_device.h » ('j') | media/audio/clockless_audio_sink.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/media/service/cast_mojo_media_client.h" 5 #include "chromecast/media/service/cast_mojo_media_client.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "chromecast/media/cma/backend/media_pipeline_backend_factory.h" 8 #include "chromecast/media/cma/backend/media_pipeline_backend_factory.h"
9 #include "chromecast/media/service/cast_renderer.h" 9 #include "chromecast/media/service/cast_renderer.h"
10 #include "chromecast/public/media/media_pipeline_backend.h" 10 #include "chromecast/public/media/media_pipeline_backend.h"
(...skipping 24 matching lines...) Expand all
35 void Play() final { NOTREACHED(); } 35 void Play() final { NOTREACHED(); }
36 bool SetVolume(double volume) final { 36 bool SetVolume(double volume) final {
37 NOTREACHED(); 37 NOTREACHED();
38 return false; 38 return false;
39 } 39 }
40 ::media::OutputDeviceInfo GetOutputDeviceInfo() final { 40 ::media::OutputDeviceInfo GetOutputDeviceInfo() final {
41 return ::media::OutputDeviceInfo(device_id_, 41 return ::media::OutputDeviceInfo(device_id_,
42 ::media::OUTPUT_DEVICE_STATUS_OK, 42 ::media::OUTPUT_DEVICE_STATUS_OK,
43 ::media::AudioParameters()); 43 ::media::AudioParameters());
44 } 44 }
45 bool OptimizedForHardwareParameter() final {
DaleCurtis 2017/05/01 22:55:08 Line above and below.
flim-chromium 2017/05/15 15:15:57 Done.
46 NOTREACHED();
47 return true;
48 }
45 bool CurrentThreadIsRenderingThread() final { 49 bool CurrentThreadIsRenderingThread() final {
46 NOTREACHED(); 50 NOTREACHED();
47 return false; 51 return false;
48 } 52 }
49 53
50 private: 54 private:
51 ~CastAudioRendererSink() final {} 55 ~CastAudioRendererSink() final {}
52 56
53 std::string device_id_; 57 std::string device_id_;
54 DISALLOW_COPY_AND_ASSIGN(CastAudioRendererSink); 58 DISALLOW_COPY_AND_ASSIGN(CastAudioRendererSink);
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 media_resource_tracker_); 130 media_resource_tracker_);
127 } 131 }
128 132
129 std::unique_ptr<::media::CdmFactory> CastMojoMediaClient::CreateCdmFactory( 133 std::unique_ptr<::media::CdmFactory> CastMojoMediaClient::CreateCdmFactory(
130 service_manager::mojom::InterfaceProvider* /* host_interfaces */) { 134 service_manager::mojom::InterfaceProvider* /* host_interfaces */) {
131 return create_cdm_factory_cb_.Run(); 135 return create_cdm_factory_cb_.Run();
132 } 136 }
133 137
134 } // namespace media 138 } // namespace media
135 } // namespace chromecast 139 } // namespace chromecast
OLDNEW
« no previous file with comments | « no previous file | media/audio/audio_output_device.h » ('j') | media/audio/clockless_audio_sink.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698