third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html - Issue 2836233002: Upstream service worker `fetch` tests to WPT

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html

Issue 2836233002: Upstream service worker `fetch` tests to WPT (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-argument.https.html ('k') | third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https.html » ('j') | third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html

diff --git a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html

index 5d3346e7b281a8f1fcfed2005cfb60bb1a15e8ca..5316942ba6f247d018fbf4cfa6118e4b93758e10 100644

--- a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html

+++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html

@@ -1,6 +1,5 @@

<!DOCTYPE html>

-<script src="resources/testharness-helpers.js"></script>

@@ -17,6 +16,7 @@ promise_test(function(t) {

return with_iframe(scope);

})

.then(function(frame) {

+ add_completion_callback(function() { frame.remove(); });

Marijn Kruisselbrink 2017/04/27 17:05:23 nit: Should this be t.add_cleanup, rather than the

mike3 2017/04/27 18:27:19 Agreed. Beyond being more consistent, `add_cleanup

var channel = new MessageChannel();

var saw_message = new Promise(function(resolve) {

channel.port1.onmessage = function(e) { resolve(e.data); }

@@ -24,7 +24,6 @@ promise_test(function(t) {

var worker = frame.contentWindow.navigator.serviceWorker.controller;

worker.postMessage({port: channel.port2}, [channel.port2]);

- frame.remove();

return saw_message;

})

.then(function(message) {