third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-event-async-respond-with.html - Issue 2836233002: Upstream service worker `fetch` tests to WPT

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-event-async-respond-with.html

Issue 2836233002: Upstream service worker `fetch` tests to WPT (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https.html ('K') | « third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-event-test-worker.js ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-event-headers.html » ('j') | third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-event-headers.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

	2 <!-- This test is prefixed with `chromium.` because the equivalent version

	3 available in Web Platform Tests is known to cause timeout errors in the

	4 Chromium automated build system. They should be maintained only to preserve

	5 test converage until the corresponding versions in Web Platform Tests can be

	6 made to pass consistently. See

	7 https://codereview.chromium.org/2805313003/ -->
	Marijn Kruisselbrink 2017/04/27 17:05:23 Is there a bug you can link to instead of a code r Is there a bug you can link to instead of a code review? mike3 2017/04/27 18:27:19 I was linking to the code review thread because th Show quoted text On 2017/04/27 17:05:23, Marijn Kruisselbrink wrote: > Is there a bug you can link to instead of a code review? I was linking to the code review thread because that is where Matt and I decided on this approach. That said, issue 658997 is just as helpful (and probably more to the point): https://crbug.com/658997 I'll update with references to that instead.
2 <script src="../resources/testharness.js"></script>	8 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	9 <script src="../resources/testharnessreport.js"></script>

4 <script src="resources/test-helpers.js"></script>	10 <script src="resources/test-helpers.js"></script>

5 <script>	11 <script>

6 promise_test(function(t) {	12 promise_test(function(t) {

7 var script = 'resources/fetch-event-async-respond-with-worker.js';	13 var script = 'resources/fetch-event-async-respond-with-worker.js';

8 var scope = 'resources/simple.html';	14 var scope = 'resources/simple.html';

9	15

10 return service_worker_unregister_and_register(t, script, scope)	16 return service_worker_unregister_and_register(t, script, scope)

11 .then(function(registration) {	17 .then(function(registration) {

(...skipping 12 matching lines...) Expand all Loading...
24	30

25 worker.postMessage({port: channel.port2}, [channel.port2]);	31 worker.postMessage({port: channel.port2}, [channel.port2]);

26 return saw_message;	32 return saw_message;

27 })	33 })

28 .then(function(message) {	34 .then(function(message) {

29 assert_equals(message, 'PASS');	35 assert_equals(message, 'PASS');

30 return service_worker_unregister_and_done(t, scope);	36 return service_worker_unregister_and_done(t, scope);

31 })	37 })

32 }, 'Calling respondWith asynchronously throws an exception');	38 }, 'Calling respondWith asynchronously throws an exception');

33 </script>	39 </script>

OLD	NEW