Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc

Issue 283623002: Add support for passing an arbitrary parameter to an IPC message handler. The motivation is for Web… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: sync Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/utf_string_conversions.h" 5 #include "base/strings/utf_string_conversions.h"
6 #include "chrome/browser/spellchecker/spellcheck_factory.h" 6 #include "chrome/browser/spellchecker/spellcheck_factory.h"
7 #include "chrome/browser/spellchecker/spellcheck_message_filter.h" 7 #include "chrome/browser/spellchecker/spellcheck_message_filter.h"
8 #include "chrome/browser/spellchecker/spellcheck_service.h" 8 #include "chrome/browser/spellchecker/spellcheck_service.h"
9 #include "chrome/common/spellcheck_marker.h" 9 #include "chrome/common/spellcheck_marker.h"
10 #include "chrome/common/spellcheck_messages.h" 10 #include "chrome/common/spellcheck_messages.h"
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 results.push_back( 94 results.push_back(
95 SpellCheckResult(kDecoration, kLocation, kLength, kReplacement)); 95 SpellCheckResult(kDecoration, kLocation, kLength, kReplacement));
96 96
97 scoped_refptr<TestingSpellCheckMessageFilter> filter( 97 scoped_refptr<TestingSpellCheckMessageFilter> filter(
98 new TestingSpellCheckMessageFilter); 98 new TestingSpellCheckMessageFilter);
99 filter->GetSpellcheckService()->GetCustomDictionary()->AddWord(kCustomWord); 99 filter->GetSpellcheckService()->GetCustomDictionary()->AddWord(kCustomWord);
100 filter->OnTextCheckComplete( 100 filter->OnTextCheckComplete(
101 kRouteId, kCallbackId, kMarkers, kSuccess, kText, results); 101 kRouteId, kCallbackId, kMarkers, kSuccess, kText, results);
102 EXPECT_EQ(static_cast<size_t>(1), filter->sent_messages.size()); 102 EXPECT_EQ(static_cast<size_t>(1), filter->sent_messages.size());
103 103
104 int sent_identifier = -1; 104 SpellCheckMsg_RespondSpellingService::Param params;
105 bool sent_success = false; 105 bool ok = SpellCheckMsg_RespondSpellingService::Read(
106 base::string16 sent_text; 106 filter->sent_messages[0], & params);
107 std::vector<SpellCheckResult> sent_results; 107 int sent_identifier = params.a;
108 bool ok = SpellCheckMsg_RespondSpellingService::Read(filter->sent_messages[0], 108 bool sent_success = params.b;
109 &sent_identifier, 109 base::string16 sent_text = params.c;
110 &sent_success, 110 std::vector<SpellCheckResult> sent_results = params.d;
111 &sent_text,
112 &sent_results);
113 EXPECT_TRUE(ok); 111 EXPECT_TRUE(ok);
114 EXPECT_EQ(kCallbackId, sent_identifier); 112 EXPECT_EQ(kCallbackId, sent_identifier);
115 EXPECT_EQ(kSuccess, sent_success); 113 EXPECT_EQ(kSuccess, sent_success);
116 EXPECT_EQ(kText, sent_text); 114 EXPECT_EQ(kText, sent_text);
117 EXPECT_EQ(static_cast<size_t>(1), sent_results.size()); 115 EXPECT_EQ(static_cast<size_t>(1), sent_results.size());
118 EXPECT_EQ(kDecoration, sent_results[0].decoration); 116 EXPECT_EQ(kDecoration, sent_results[0].decoration);
119 EXPECT_EQ(kLocation, sent_results[0].location); 117 EXPECT_EQ(kLocation, sent_results[0].location);
120 EXPECT_EQ(kLength, sent_results[0].length); 118 EXPECT_EQ(kLength, sent_results[0].length);
121 EXPECT_EQ(kReplacement, sent_results[0].replacement); 119 EXPECT_EQ(kReplacement, sent_results[0].replacement);
122 } 120 }
123 121
124 TEST(SpellCheckMessageFilterTest, OnTextCheckCompleteTest) { 122 TEST(SpellCheckMessageFilterTest, OnTextCheckCompleteTest) {
125 std::vector<SpellCheckResult> results; 123 std::vector<SpellCheckResult> results;
126 results.push_back(SpellCheckResult( 124 results.push_back(SpellCheckResult(
127 SpellCheckResult::SPELLING, 0, 6, base::ASCIIToUTF16("Hello"))); 125 SpellCheckResult::SPELLING, 0, 6, base::ASCIIToUTF16("Hello")));
128 results.push_back(SpellCheckResult( 126 results.push_back(SpellCheckResult(
129 SpellCheckResult::SPELLING, 7, 7, base::ASCIIToUTF16("world"))); 127 SpellCheckResult::SPELLING, 7, 7, base::ASCIIToUTF16("world")));
130 128
131 scoped_refptr<TestingSpellCheckMessageFilter> filter( 129 scoped_refptr<TestingSpellCheckMessageFilter> filter(
132 new TestingSpellCheckMessageFilter); 130 new TestingSpellCheckMessageFilter);
133 filter->OnTextCheckComplete(1, 1, std::vector<SpellCheckMarker>(), 131 filter->OnTextCheckComplete(1, 1, std::vector<SpellCheckMarker>(),
134 true, base::ASCIIToUTF16("Helllo walrd"), results); 132 true, base::ASCIIToUTF16("Helllo walrd"), results);
135 EXPECT_EQ(static_cast<size_t>(1), filter->sent_messages.size()); 133 EXPECT_EQ(static_cast<size_t>(1), filter->sent_messages.size());
136 134
137 int sent_identifier = -1; 135 SpellCheckMsg_RespondSpellingService::Param params;
138 bool sent_success = false; 136 bool ok = SpellCheckMsg_RespondSpellingService::Read(
139 base::string16 sent_text; 137 filter->sent_messages[0], & params);
140 std::vector<SpellCheckResult> sent_results; 138 base::string16 sent_text = params.c;
141 bool ok = SpellCheckMsg_RespondSpellingService::Read(filter->sent_messages[0], 139 std::vector<SpellCheckResult> sent_results = params.d;
142 &sent_identifier,
143 &sent_success,
144 &sent_text,
145 &sent_results);
146 EXPECT_TRUE(ok); 140 EXPECT_TRUE(ok);
147 EXPECT_EQ(static_cast<size_t>(2), sent_results.size()); 141 EXPECT_EQ(static_cast<size_t>(2), sent_results.size());
148 } 142 }
149 #endif 143 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698