Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2836143003: Invalidate border/outline on color change only if they use current color (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
index 57050627de17fafbb5179957e1627db37958916b..6f64ffa686e2f3d531afab7d770550bb5ad0564c 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
@@ -1543,7 +1543,8 @@ StyleDifference LayoutObject::AdjustStyleDifference(
// needed if we have style or text affected by these properties.
if (diff.TextDecorationOrColorChanged() &&
!diff.NeedsFullPaintInvalidation()) {
- if (Style()->HasBorder() || Style()->HasOutline() ||
+ if (Style()->HasBorderColorReferencingCurrentColor() ||
wkorman 2017/04/24 22:05:41 Could add unit tests for this, BorderData, and Com
Xianzhu 2017/04/24 22:36:48 Added ComputedStyleTest.HasOutlineWithCurrentColor
+ Style()->IsOutlineColorCurrentColor() ||
Style()->HasBackgroundRelatedColorReferencingCurrentColor() ||
// Skip any text nodes that do not contain text boxes. Whitespace cannot
// be skipped or we will miss invalidating decorations (e.g.,

Powered by Google App Engine
This is Rietveld 408576698