Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/browser/policy/cloud/test_request_interceptor.cc

Issue 2836143002: Use TaskScheduler instead of blocking pool in test_request_interceptor.cc. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/policy/cloud/test_request_interceptor.h" 5 #include "chrome/browser/policy/cloud/test_request_interceptor.h"
6 6
7 #include <limits> 7 #include <limits>
8 #include <memory> 8 #include <memory>
9 #include <queue> 9 #include <queue>
10 #include <utility> 10 #include <utility>
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/bind.h" 13 #include "base/bind.h"
14 #include "base/bind_helpers.h" 14 #include "base/bind_helpers.h"
15 #include "base/macros.h" 15 #include "base/macros.h"
16 #include "base/run_loop.h" 16 #include "base/run_loop.h"
17 #include "base/sequenced_task_runner.h" 17 #include "base/sequenced_task_runner.h"
18 #include "base/threading/sequenced_worker_pool.h" 18 #include "base/task_scheduler/post_task.h"
19 #include "base/threading/thread_task_runner_handle.h" 19 #include "base/threading/thread_task_runner_handle.h"
20 #include "content/public/browser/browser_thread.h"
21 #include "net/base/net_errors.h" 20 #include "net/base/net_errors.h"
22 #include "net/base/upload_bytes_element_reader.h" 21 #include "net/base/upload_bytes_element_reader.h"
23 #include "net/base/upload_data_stream.h" 22 #include "net/base/upload_data_stream.h"
24 #include "net/base/upload_element_reader.h" 23 #include "net/base/upload_element_reader.h"
25 #include "net/test/url_request/url_request_mock_http_job.h" 24 #include "net/test/url_request/url_request_mock_http_job.h"
26 #include "net/url_request/url_request_error_job.h" 25 #include "net/url_request/url_request_error_job.h"
27 #include "net/url_request/url_request_filter.h" 26 #include "net/url_request/url_request_filter.h"
28 #include "net/url_request/url_request_interceptor.h" 27 #include "net/url_request/url_request_interceptor.h"
29 #include "net/url_request/url_request_test_job.h" 28 #include "net/url_request/url_request_test_job.h"
30 #include "url/gurl.h" 29 #include "url/gurl.h"
(...skipping 26 matching lines...) Expand all
57 net::URLRequestJob* BadRequestJobCallback( 56 net::URLRequestJob* BadRequestJobCallback(
58 net::URLRequest* request, 57 net::URLRequest* request,
59 net::NetworkDelegate* network_delegate) { 58 net::NetworkDelegate* network_delegate) {
60 return HttpErrorJobCallback("400 Bad request", request, network_delegate); 59 return HttpErrorJobCallback("400 Bad request", request, network_delegate);
61 } 60 }
62 61
63 net::URLRequestJob* FileJobCallback(const base::FilePath& file_path, 62 net::URLRequestJob* FileJobCallback(const base::FilePath& file_path,
64 net::URLRequest* request, 63 net::URLRequest* request,
65 net::NetworkDelegate* network_delegate) { 64 net::NetworkDelegate* network_delegate) {
66 return new net::URLRequestMockHTTPJob( 65 return new net::URLRequestMockHTTPJob(
67 request, 66 request, network_delegate, file_path,
68 network_delegate, 67 base::CreateTaskRunnerWithTraits(
69 file_path, 68 base::TaskTraits()
70 content::BrowserThread::GetBlockingPool() 69 .MayBlock()
71 ->GetTaskRunnerWithShutdownBehavior( 70 .WithPriority(base::TaskPriority::BACKGROUND)
72 base::SequencedWorkerPool::SKIP_ON_SHUTDOWN)); 71 .WithShutdownBehavior(
72 base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN)));
73 } 73 }
74 74
75 // Parses the upload data in |request| into |request_msg|, and validates the 75 // Parses the upload data in |request| into |request_msg|, and validates the
76 // request. The query string in the URL must contain the |expected_type| for 76 // request. The query string in the URL must contain the |expected_type| for
77 // the "request" parameter. Returns true if all checks succeeded, and the 77 // the "request" parameter. Returns true if all checks succeeded, and the
78 // request data has been parsed into |request_msg|. 78 // request data has been parsed into |request_msg|.
79 bool ValidRequest(net::URLRequest* request, 79 bool ValidRequest(net::URLRequest* request,
80 const std::string& expected_type, 80 const std::string& expected_type,
81 em::DeviceManagementRequest* request_msg) { 81 em::DeviceManagementRequest* request_msg) {
82 if (request->method() != "POST") 82 if (request->method() != "POST")
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 FROM_HERE, 347 FROM_HERE,
348 base::Bind( 348 base::Bind(
349 base::IgnoreResult(&base::TaskRunner::PostTask), 349 base::IgnoreResult(&base::TaskRunner::PostTask),
350 base::ThreadTaskRunnerHandle::Get(), 350 base::ThreadTaskRunnerHandle::Get(),
351 FROM_HERE, 351 FROM_HERE,
352 run_loop.QuitClosure())); 352 run_loop.QuitClosure()));
353 run_loop.Run(); 353 run_loop.Run();
354 } 354 }
355 355
356 } // namespace policy 356 } // namespace policy
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698