chrome/browser/notifications/notification_common.cc - Issue 2836093002: Make Android notifications rely on the native notification flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_common.cc

Issue 2836093002: Make Android notifications rely on the native notification flag (Closed)

Patch Set: Add an additional check for Android Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/notification_common.cc

diff --git a/chrome/browser/notifications/notification_common.cc b/chrome/browser/notifications/notification_common.cc

index 92f44b4be371fd8645d68e60a57e87cbf7692b5c..3320f6af8eb14996d7f69bf38bc66bad5a8caa5e 100644

--- a/chrome/browser/notifications/notification_common.cc

+++ b/chrome/browser/notifications/notification_common.cc

@@ -14,6 +14,7 @@

void NotificationCommon::OpenNotificationSettings(

content::BrowserContext* browser_context) {

#if defined(OS_ANDROID)

+ // Android settings are opened directly from Java

NOTIMPLEMENTED();

#else

Profile* profile = Profile::FromBrowserContext(browser_context);

« no previous file with comments | « no previous file | chrome/browser/notifications/notification_display_service_factory.cc » ('j') | no next file with comments »