components/grpc_support/test/get_stream_engine.h - Issue 2836063005: [cronet] Add mechanism for restarting CronetEnvironment

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/grpc_support/test/get_stream_engine.h

Issue 2836063005: [cronet] Add mechanism for restarting CronetEnvironment (Closed)

Patch Set: per #5 Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/grpc_support/bidirectional_stream_unittest.cc ('K') | « components/grpc_support/bidirectional_stream_unittest.cc ('k') | components/grpc_support/test/get_stream_engine.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_GRPC_SUPPORT_TEST_GET_REQUEST_CONTEXT_GETTER_H_	5 #ifndef COMPONENTS_GRPC_SUPPORT_TEST_GET_REQUEST_CONTEXT_GETTER_H_

6 #define COMPONENTS_GRPC_SUPPORT_TEST_GET_REQUEST_CONTEXT_GETTER_H_	6 #define COMPONENTS_GRPC_SUPPORT_TEST_GET_REQUEST_CONTEXT_GETTER_H_

7	7

8 struct stream_engine;	8 struct stream_engine;

9	9

10 namespace grpc_support {	10 namespace grpc_support {

11	11

12 // Returns a stream_engine* for testing with the QuicTestServer.	12 // Returns a stream_engine* for testing with the QuicTestServer.

13 // The engine returned should resolve kTestServerHost as localhost:\|port\|,	13 // The engine returned should resolve kTestServerHost as localhost:\|port\|,

14 // and should have kTestServerHost configured as a QUIC server.	14 // and should have kTestServerHost configured as a QUIC server.

15 stream_engine* GetTestStreamEngine(int port);	15 stream_engine* GetTestStreamEngine(int port);

16	16

	17 void StartTestStreamEngine(int port);
	mef 2017/04/26 22:19:41 Public methods need comments. Public methods need comments. lilyhoughton 2017/04/27 13:53:39 Done, though PTAL to make sure it's sufficiently c Show quoted text On 2017/04/26 22:19:41, mef wrote: > Public methods need comments. Done, though PTAL to make sure it's sufficiently clear etc.
	18 void ShutdownTestStreamEngine();

	19

17 } // namespace grpc_support	20 } // namespace grpc_support

18	21

19 #endif // COMPONENTS_GRPC_SUPPORT_TEST_GET_REQUEST_CONTEXT_GETTER_H_	22 #endif // COMPONENTS_GRPC_SUPPORT_TEST_GET_REQUEST_CONTEXT_GETTER_H_

OLD	NEW