Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2836043002: Revert "Reland "Use off-heap data for type feedback in PolymorphicInstanceCallInstr"" (Closed)

Created:
3 years, 8 months ago by erikcorry
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Reland "Use off-heap data for type feedback in PolymorphicInstanceCallInstr"" This reverts commit 694ddfcdd3ae166858a2bf979287b0eefb21814c. Original code review: https://codereview.chromium.org/2809583002/ Reverted because of failures on Android: python tools/test.py -mrelease -cprecompiler -rdart_precompiled -aarm -sandroid --use-blobs -t480 language/vm/canonicalization_preserves_deopt_test R=vegorov@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e753278c5f333f25f683759d89e37c2681364ade

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+895 lines, -834 lines) Patch
M runtime/vm/aot_optimizer.cc View 5 chunks +10 lines, -13 lines 0 comments Download
M runtime/vm/assembler_arm.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 6 chunks +31 lines, -38 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 4 chunks +72 lines, -188 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 2 chunks +107 lines, -28 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 2 chunks +107 lines, -28 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 3 chunks +105 lines, -38 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 2 chunks +108 lines, -35 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 2 chunks +108 lines, -28 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 18 chunks +57 lines, -34 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/il_printer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/il_printer.cc View 3 chunks +5 lines, -47 lines 0 comments Download
M runtime/vm/intermediate_language.h View 4 chunks +9 lines, -74 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 7 chunks +25 lines, -200 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 3 chunks +28 lines, -13 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/jit_optimizer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/jit_optimizer.cc View 7 chunks +92 lines, -17 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
erikcorry
3 years, 8 months ago (2017-04-24 15:01:35 UTC) #1
erikcorry
3 years, 8 months ago (2017-04-24 15:04:35 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e753278c5f333f25f683759d89e37c2681364ade (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698