Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 283603004: Add missing UMA histograms for Startup.AppListFirstPaint* (Closed)

Created:
6 years, 7 months ago by tapted
Modified:
6 years, 7 months ago
Reviewers:
benwells, Ilya Sherman
CC:
chromium-reviews, jar (doing other things), asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Add missing UMA histograms for Startup.AppListFirstPaint* These were added in http://crrev.com/218723 but without a histograms change in src/tools/metrics/histograms or src-internal/tools/histograms. The values cover the gap in measurement between when the app launcher view is created and when it actually gets painted. Similar to Startup.BrowserWindowDisplay. BUG=274049 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270069

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tapted
@benwells: just checking we still want these before sending to OWNERS. I guess we should ...
6 years, 7 months ago (2014-05-13 03:54:06 UTC) #1
benwells
On 2014/05/13 03:54:06, tapted wrote: > @benwells: just checking we still want these before sending ...
6 years, 7 months ago (2014-05-13 04:06:14 UTC) #2
benwells
On 2014/05/13 04:06:14, benwells wrote: > On 2014/05/13 03:54:06, tapted wrote: > > @benwells: just ...
6 years, 7 months ago (2014-05-13 04:06:25 UTC) #3
tapted
+isherman. Hi Ilya, PTAL for OWNERS. This is following the pattern in use by the ...
6 years, 7 months ago (2014-05-13 04:09:53 UTC) #4
Ilya Sherman
LGTM
6 years, 7 months ago (2014-05-13 04:33:50 UTC) #5
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 7 months ago (2014-05-13 04:45:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/283603004/1
6 years, 7 months ago (2014-05-13 04:46:26 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 11:47:27 UTC) #8
Message was sent while issue was closed.
Change committed as 270069

Powered by Google App Engine
This is Rietveld 408576698