Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5208)

Unified Diff: chrome/test/chromedriver/test/run_py_tests.py

Issue 2836023003: fix testWindowMaximize bug (Closed)
Patch Set: nit Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_desktop_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/test/run_py_tests.py
diff --git a/chrome/test/chromedriver/test/run_py_tests.py b/chrome/test/chromedriver/test/run_py_tests.py
index 41eb401018221b5f692951954f4f8b9959070d69..dce78013ac4df70909d9d2e14b4cf72e7594389f 100755
--- a/chrome/test/chromedriver/test/run_py_tests.py
+++ b/chrome/test/chromedriver/test/run_py_tests.py
@@ -99,10 +99,7 @@ _OS_SPECIFIC_FILTER['linux'] = [
# Xvfb doesn't support maximization.
'ChromeDriverTest.testWindowMaximize',
]
-_OS_SPECIFIC_FILTER['mac'] = [
- # https://bugs.chromium.org/p/chromedriver/issues/detail?id=1779
- 'ChromeDriverTest.testWindowMaximize',
-]
+_OS_SPECIFIC_FILTER['mac'] = []
_DESKTOP_NEGATIVE_FILTER = [
# Desktop doesn't support touch (without --touch-events).
@@ -864,11 +861,11 @@ class ChromeDriverTest(ChromeDriverBaseTestWithWebServer):
def testWindowMaximize(self):
self._driver.SetWindowPosition(100, 200)
- self._driver.SetWindowSize(600, 400)
+ self._driver.SetWindowSize(500, 300)
self._driver.MaximizeWindow()
self.assertNotEqual([100, 200], self._driver.GetWindowPosition())
- self.assertNotEqual([600, 400], self._driver.GetWindowSize())
+ self.assertNotEqual([500, 300], self._driver.GetWindowSize())
# Set size first so that the window isn't moved offscreen.
# See https://bugs.chromium.org/p/chromedriver/issues/detail?id=297.
self._driver.SetWindowSize(600, 400)
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_desktop_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698