Make the HistoryMenuBridge::HistoryItem co-own the NSMenuItem. This hopefully fixes a top-crash.

Make the HistoryMenuBridge::HistoryItem co-own the NSMenuItem. This hopefully fixes a top-crash.

BUG=46289
TEST=Open 3 windows, with 10-12 tabs in each. Cmd+W rapidly. Chrome doesn't crash. See bug for details.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50134

[Robert Sesek, 2010-06-17 15:50:12]

P1 top-crasher plz.

[John Grabowski, 2010-06-17 18:53:55]

http://codereview.chromium.org/2836008/diff/1/3
File chrome/browser/cocoa/history_menu_bridge.mm (left):

http://codereview.chromium.org/2836008/diff/1/3#oldcode301
chrome/browser/cocoa/history_menu_bridge.mm:301: scoped_nsobject<NSMenuItem>
menu_item(
Perhaps there is an easier solution?
If you just do an autorelease/retain of this menu item, the item's lifetime will
probably be correct.

Can you try that out?

[Robert Sesek, 2010-06-17 19:05:44]

http://codereview.chromium.org/2836008/diff/1/3
File chrome/browser/cocoa/history_menu_bridge.mm (left):

http://codereview.chromium.org/2836008/diff/1/3#oldcode301
chrome/browser/cocoa/history_menu_bridge.mm:301: scoped_nsobject<NSMenuItem>
menu_item(
On 2010/06/17 18:53:55, John Grabowski wrote:
> Perhaps there is an easier solution?
> If you just do an autorelease/retain of this menu item, the item's lifetime
will
> probably be correct.
> 
> Can you try that out?
> 

I tried that as well as nil-ing the item in ClearMenuSection().  It happened
less frequently (or maybe I just didn't repro correctly), but it still happened.
 I think this solution is both safer and technically correct, and it makes
memory ownership explicitly clear.

[John Grabowski, 2010-06-17 19:30:44]

LGTM

http://codereview.chromium.org/2836008/diff/1/2
File chrome/browser/cocoa/history_menu_bridge.h (right):

http://codereview.chromium.org/2836008/diff/1/2#newcode92
chrome/browser/cocoa/history_menu_bridge.h:92: // the NSMenu, but during a
rebuild flood (if the user closes a lot of tabs
This is co-owned with the NSMenu.  but ...
-->
Strong; NSMenu also retains this.  during a rebuild flood, ...

[John Grabowski, 2010-06-17 19:31:18]

Oh -- please add details in this CL description on how to repro for the testers
to verify properly.