Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2836003002: More status changes for new version of Firefox. (Closed)

Created:
3 years, 8 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 8 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, Emily Fortuna
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add where the lines belong. #

Total comments: 3

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -28 lines) Patch
M tests/co19/co19-co19.status View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 7 chunks +9 lines, -20 lines 0 comments Download
M tests/co19/co19-dartium.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Lasse Reichstein Nielsen
https://codereview.chromium.org/2836003002/diff/1/tests/html/html.status File tests/html/html.status (left): https://codereview.chromium.org/2836003002/diff/1/tests/html/html.status#oldcode283 tests/html/html.status:283: # All changes should be accompanied by platform support ...
3 years, 8 months ago (2017-04-24 11:53:31 UTC) #2
Bill Hesse
https://codereview.chromium.org/2836003002/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/2836003002/diff/1/tests/co19/co19-dart2js.status#newcode8353 tests/co19/co19-dart2js.status:8353: [ $runtime == dartium || $compiler == dart2js ] ...
3 years, 8 months ago (2017-04-24 12:04:14 UTC) #3
Lasse Reichstein Nielsen
ptal
3 years, 8 months ago (2017-04-24 12:38:34 UTC) #4
Bill Hesse
LGTM, with comment about dartium status. https://codereview.chromium.org/2836003002/diff/20001/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/2836003002/diff/20001/tests/co19/co19-dart2js.status#newcode8342 tests/co19/co19-dart2js.status:8342: [ $runtime == ...
3 years, 8 months ago (2017-04-24 13:18:58 UTC) #5
Lasse Reichstein Nielsen
https://codereview.chromium.org/2836003002/diff/20001/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/2836003002/diff/20001/tests/co19/co19-dart2js.status#newcode8342 tests/co19/co19-dart2js.status:8342: [ $runtime == dartium || $compiler == dart2js ] ...
3 years, 8 months ago (2017-04-24 13:23:42 UTC) #6
Lasse Reichstein Nielsen
3 years, 8 months ago (2017-04-24 13:24:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6fa31daf2736d3768f968184ff81510b34a56b96 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698