Issue 29388. Resynthesize non-generic types for ReferenceInfo lazily.

Issue 29388. Resynthesize non-generic types for ReferenceInfo lazily.

This helps with preventing infinite recursion in getReferenceInfo(),
which does cache ReferenceInfo instances, but we were doing too much
work in the ReferenceInfo constructor.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/29388

Committed: https://github.com/dart-lang/sdk/commit/ebf0bb6ee0f4dc7fc4ecb5c502fda3930df61332

[Brian Wilkerson, 2017-04-24 18:35:47]

lgtm

https://codereview.chromium.org/2835903003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/2835903003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:1351: //            &&
!_isBeingInstantiatedToBounds
Should we remove the commented out code?

[scheglov, 2017-04-24 18:45:16]

Description was changed from

==========
Issue 29388. Resynthesize non-generic types for ReferenceInfo lazily.

This helps with preventing infinite recursion in getReferenceInfo(),
which does cache ReferenceInfo instances, but we were doing too much
work in the ReferenceInfo constructor.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/29388
==========

to

==========
Issue 29388. Resynthesize non-generic types for ReferenceInfo lazily.

This helps with preventing infinite recursion in getReferenceInfo(),
which does cache ReferenceInfo instances, but we were doing too much
work in the ReferenceInfo constructor.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/29388

Committed:
https://github.com/dart-lang/sdk/commit/ebf0bb6ee0f4dc7fc4ecb5c502fda3930df61332
==========

[scheglov, 2017-04-24 18:45:18]

Committed patchset #1 (id:1) manually as
ebf0bb6ee0f4dc7fc4ecb5c502fda3930df61332 (presubmit successful).