Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2835783002: Change painting root for squashed layers to the composting container (Closed)

Created:
3 years, 8 months ago by trchen
Modified:
3 years, 8 months ago
Reviewers:
chrishtr
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change painting root for squashed layers to the composting container This is an alternative fix to crbug.com/712783 Too crazy. Too complex. Forget about it. BUG=712783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 4 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
trchen
3 years, 8 months ago (2017-04-21 23:13:53 UTC) #4
Message was sent while issue was closed. 
I tried to fix the root cause in the squashing logic. I agree this involves too
much complexity. :(

Your proposal to detect squashing in PaintLayerPainter is the best trade-off I
think.

Powered by Google App Engine
This is Rietveld 408576698