add an option to turn off errors from strong mode is-checks

pkg/dev_compiler/test/browser/language_tests.js

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
       function(dart_sdk, async_helper, expect, unittest, is, require) {
   'use strict';
 
   async_helper = async_helper.async_helper;
   let minitest = expect.minitest;
   let mochaOnError = window.onerror;
   dart_sdk.dart.trapRuntimeErrors(false);
   dart_sdk.dart.ignoreWhitelistedErrors(false);
+  dart_sdk.dart.failForWeakModeIsChecks(false);
   dart_sdk._isolate_helper.startRootIsolate(function() {}, []);
   // Make it easier to debug test failures and required for formatter test that
   // assumes custom formatters are enabled.
   dart_sdk._debugger.registerDevtoolsFormatter();
 
   let html_config = unittest.html_config;
   // Test attributes are a list of strings, or a string for a single
   // attribute. Valid attributes are:
   //
   //   'pass' - test passes (default)
@@ skipping 101 matching lines @@
       'cyclic_type_test_03_multi': fail,
       'cyclic_type_test_04_multi': fail,
 
       // Deferred libraries are not actually deferred. These tests all test
       // that synchronous access to the library fails.
       'deferred_call_empty_before_load_test': fail,
       'deferred_not_loaded_check_test': fail,
       'deferred_redirecting_factory_test': fail,
       'deferred_static_seperate_test': fail,
 
-      'deferred_regression_22995_test': fail, // Strong mode "is" rejects some type tests.
       'double_int_to_string_test': fail,
       'dynamic_test': fail,
       'exception_test': fail,
       'execute_finally6_test': fail,
       'expect_test': fail,
       'extends_test_lib': fail,
       'external_test_10_multi': fail,
       'external_test_13_multi': fail,
       'external_test_20_multi': fail,
       'f_bounded_quantification3_test': fail,
       'field_increment_bailout_test': fail,
       'field_optimization3_test': fail,
       'field_type_check2_test_01_multi': fail, // 01: dynamic type error
       'final_syntax_test_08_multi': fail,
       'first_class_types_test': fail,
       'for_variable_capture_test': is.firefox('<=50') ? pass : fail,
-      'function_subtype0_test': fail,
-      'function_subtype1_test': fail,
-      'function_subtype2_test': fail,
-      'function_subtype3_test': fail,
-      'function_subtype_bound_closure0_test': fail,
-      'function_subtype_bound_closure1_test': fail,
-      'function_subtype_bound_closure2_test': fail,
-      'function_subtype_bound_closure3_test': fail,
-      'function_subtype_bound_closure4_test': fail,
-      'function_subtype_bound_closure5_test': fail,
-      'function_subtype_bound_closure5a_test': fail,
-      'function_subtype_bound_closure6_test': fail,
-      'function_subtype_call0_test': fail, // Strong mode "is" rejects some type tests.
-      'function_subtype_call1_test': fail,
-      'function_subtype_call2_test': fail,
-      'function_subtype_factory0_test': fail,
-      'function_subtype_inline0_test': fail,
-      'function_subtype_local0_test': fail,
-      'function_subtype_local1_test': fail,
-      'function_subtype_local2_test': fail,
-      'function_subtype_local3_test': fail,
-      'function_subtype_local4_test': fail,
-      'function_subtype_local5_test': fail,
       'function_subtype_named1_test': fail,
       'function_subtype_named2_test': fail,
-      'function_subtype_not0_test': fail,
-      'function_subtype_not1_test': fail,
-      'function_subtype_not2_test': fail,
-      'function_subtype_not3_test': fail,
       'function_subtype_optional1_test': fail,
       'function_subtype_optional2_test': fail,
-      'function_subtype_top_level0_test': fail,
-      'function_subtype_top_level1_test': fail,
       'function_subtype_typearg2_test': fail,
       'function_subtype_typearg4_test': fail,
-      'function_type_alias2_test': fail,
       'function_type_alias3_test': fail,
-      'function_type_alias4_test': fail,
       'function_type_alias6_test_none_multi': fail,
       'generic_instanceof_test': fail, // runtime strong mode reject
       'generic_instanceof2_test': fail,
       'generic_is_check_test': fail,
       'generic_methods_dynamic_test_02_multi': fail,
       'generic_methods_dynamic_test_04_multi': fail,
       'generic_methods_recursive_bound_test_03_multi': fail,
       'generic_methods_simple_as_expression_test_02_multi': fail,
       'getter_closure_execution_order_test': fail,
       'gc_test': 'slow',
@@ skipping 44 matching lines @@
       'stack_overflow_test': fail,
       'stacktrace_rethrow_error_test_none_multi': fail,
       'stacktrace_rethrow_error_test_withtraceparameter_multi': fail,
       'stacktrace_test': chrome_fail,
       'string_interpolate_null_test': fail,
       'switch_label2_test': fail,
       'switch_label_test': fail,
       'switch_try_catch_test': fail,
       'throwing_lazy_variable_test': fail,
       'truncdiv_test': fail,  // did not throw
-      'type_variable_nested_test': fail,  // unsound is-check
-      'type_variable_typedef_test': fail,  // unsound is-check
+      'type_variable_nested_test': fail,
 
       'bit_operations_test_01_multi': fail,
       'bit_operations_test_02_multi': fail,
       'bit_operations_test_03_multi': fail,
       'bit_operations_test_04_multi': fail,
       'bool_condition_check_test_01_multi': fail,
       'deferred_load_constants_test_none_multi': fail,
       'external_test_21_multi': fail,
       'external_test_24_multi': fail,
       'main_not_a_function_test_01_multi': fail,
@@ skipping 95 matching lines @@
     'corelib/regexp': {
       'default_arguments_test': fail,
       'UC16_test': firefox_fail,
     },
 
     'lib/async': {
       'first_regression_test': async_unittest,
       'future_or_bad_type_test_implements_multi': fail,
       'future_or_bad_type_test_none_multi': fail,
       'future_or_non_strong_test': fail,
-      'future_or_strong_test': fail,  // Strong-mode is-check fail
       'future_timeout_test': async_unittest,
       'multiple_timer_test': async_unittest,
       'futures_test': fail,
       'run_zoned6_test_01_multi': fail,
       'run_zoned9_test_01_multi': fail,
       'schedule_microtask2_test': async_unittest,
       'schedule_microtask3_test': async_unittest,
       'schedule_microtask5_test': async_unittest,
       'stream_controller_async_test': async_unittest,
       'stream_first_where_test': async_unittest,
@@ skipping 577 matching lines @@
 
     for (let action of unittest_tests) {
       try {
         action();
       } catch (e) {
         console.error("Caught error tying to setup test:", e);
       }
     }
   });
 });