Place primary screen before secondary screens in picker

Place primary screen before secondary screens in picker

The DesktopMediaPicker treats the contents of the DesktopMediaList as an
ordered list of sources. This change ensures the primary display is
always in the first position in the picker.

BUG=372444
TEST=Under ChromeOS connect/disconnect/reconnect secondary screen and
observe that the primary display is in the first position in the picker.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271669

[robert.bradford, 2014-05-19 11:34:22]

Hi Sergey, could you take a look at this change please.

[Sergey Ulanov, 2014-05-19 18:59:33]

LGTM.
Sorry about the delay - I was on vacation last week.

https://codereview.chromium.org/283573002/diff/1/chrome/browser/media/desktop...
File chrome/browser/media/desktop_media_list_ash.cc (right):

https://codereview.chromium.org/283573002/diff/1/chrome/browser/media/desktop...
chrome/browser/media/desktop_media_list_ash.cc:184:
sources->insert(sources->begin(), screen_source);
nit: add {} here and for the else case.

[robert.bradford, 2014-05-20 11:13:34]

The CQ bit was checked by robert.bradford@intel.com

[commit-bot: I haz the power, 2014-05-20 11:13:53]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/robert.bradford@intel.com/283573002/40001

[commit-bot: I haz the power, 2014-05-20 12:45:48]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-20 15:55:55]

Change committed as 271669