Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2835703002: Remove ReferencedNames(Builder). (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove ReferencedNames(Builder). Nobody uses them anymore, so there is no point in computing it. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d780f10d72f20fcb57facd8746d183fabb00a8c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1025 lines) Patch
M pkg/analysis_server/lib/src/status/get_handler.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/validator.dart View 2 chunks +0 lines, -112 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 5 chunks +0 lines, -417 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 3 chunks +0 lines, -20 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 12 chunks +5 lines, -471 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-21 19:22:27 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-21 20:06:39 UTC) #2
scheglov
3 years, 8 months ago (2017-04-21 21:29:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d780f10d72f20fcb57facd8746d183fabb00a8c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698