Issue 2835683002: Convert the overlay scrollbar flag to use FeatureList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2835683002: Convert the overlay scrollbar flag to use FeatureList

Created:
3 years, 8 months ago by bokan

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

More Reviews

Description

Convert the overlay scrollbar flag to use FeatureList Current implementation uses an old-styled field trial flag. To make server side configurations and client side flag handling easy and clear, convert the field trial flag to use FeatureList. BUG=710060 Review-Url: https://codereview.chromium.org/2806263005 Cr-Original-Commit-Position: refs/heads/master@{#465867} Committed: https://chromium.googlesource.com/chromium/src/+/f8b7dc953a79f8565fde8cd22642b000a236d5a5 Review-Url: https://codereview.chromium.org/2806263005 Cr-Commit-Position: refs/heads/master@{#466032} (cherry picked from commit d3ca34febe2838703bfd71217be83fb26e372257)

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -90 lines)			Patch
M	chrome/browser/about_flags.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/renderer/autofill/form_classifier_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/safe_browsing/threat_dom_details_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/android/content_startup_flags.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	3 chunks	+1 line, -3 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/site_per_process_browsertest.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/browser/site_per_process_browsertest.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	content/child/runtime_features.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/gpu/render_widget_compositor.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/render_view_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/LayoutTests/VirtualTestSuites	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ui/native_theme/BUILD.gn	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/native_theme/native_theme_aura.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	ui/native_theme/native_theme_features.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download
A	ui/native_theme/native_theme_features.cc	View	1 chunk	+31 lines, -0 lines	0 comments	Download
D	ui/native_theme/native_theme_switches.h	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	ui/native_theme/native_theme_switches.cc	View	1 chunk	+0 lines, -34 lines	0 comments	Download