Password Login Database: report correct changes from AddLogin().

components/password_manager/core/browser/login_database.h

Index: components/password_manager/core/browser/login_database.h
diff --git a/components/password_manager/core/browser/login_database.h b/components/password_manager/core/browser/login_database.h
index 70da32831ead9e9c03b56191e8f2514cd8cdacfe..8847201e87a24711f7050d3955e716a9a562930e 100644
--- a/components/password_manager/core/browser/login_database.h
+++ b/components/password_manager/core/browser/login_database.h
@@ -11,14 +11,11 @@
 #include "base/files/file_path.h"
 #include "base/pickle.h"
 #include "base/strings/string16.h"
+#include "components/password_manager/core/browser/password_store_change.h"
 #include "components/password_manager/core/browser/psl_matching_helper.h"
 #include "sql/connection.h"
 #include "sql/meta_table.h"
 
-namespace autofill {
-struct PasswordForm;
-}  // namespace autofill
-
 namespace password_manager {
 
 // Interface to the database storage of login information, intended as a helper
@@ -36,8 +33,11 @@ class LoginDatabase {
   // Reports usage metrics to UMA.
   void ReportMetrics();
 
-  // Adds |form| to the list of remembered password forms.
-  bool AddLogin(const autofill::PasswordForm& form);
+  // Adds |form| to the list of remembered password forms. Returns the list of
+  // changes applied ({}, {ADD}, {DELETE, ADD}). In the latter case the previous

[Garrett Casto, 2014/05/14 07:46:35]

nit: It's REMOVE not DELETE.

[vasilii, 2014/05/14 11:20:18]

Done.

+  // password value isn't read. Thus only the UNIQUE key columns contain the

[Garrett Casto, 2014/05/14 07:46:35]

The last two sentences are pretty confusing. I think what your trying to say is
that if the function returns {REMOVE, ADD} then the returned
PasswordStoreChangeList will have the REMOVE associated with the form that was
added not the one that was removed. Would you mind trying to clarify the
language a little bit?

I don't think that this is a problem in practice, since sync only cares about
the key, though documenting this irregularity is good.

[vasilii, 2014/05/14 11:20:18]

Done.

+  // correct value.
+  PasswordStoreChangeList AddLogin(const autofill::PasswordForm& form);
 
   // Updates remembered password form. Returns true on success and sets
   // items_changed (if non-NULL) to the number of logins updated.