Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2680)

Unified Diff: base/task_scheduler/scheduler_worker_pool_params.h

Issue 2835603005: Remove name and priority hint from SchedulerWorkerPoolParams. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_worker_pool_params.h
diff --git a/base/task_scheduler/scheduler_worker_pool_params.h b/base/task_scheduler/scheduler_worker_pool_params.h
index ca2aafc85edb6328d5bdd3ea05026b7e118b12af..67f72cc691999109e9c4ecd966d972aabe6f86b0 100644
--- a/base/task_scheduler/scheduler_worker_pool_params.h
+++ b/base/task_scheduler/scheduler_worker_pool_params.h
@@ -5,10 +5,7 @@
#ifndef BASE_TASK_SCHEDULER_SCHEDULER_WORKER_POOL_PARAMS_H_
#define BASE_TASK_SCHEDULER_SCHEDULER_WORKER_POOL_PARAMS_H_
-#include <string>
-
#include "base/task_scheduler/scheduler_worker_params.h"
-#include "base/threading/platform_thread.h"
#include "base/time/time.h"
namespace base {
@@ -23,28 +20,12 @@ class BASE_EXPORT SchedulerWorkerPoolParams final {
ONE,
};
- // Construct a scheduler worker pool parameter object. |name| will be used to
- // label the pool's threads ("TaskScheduler" + |name| + index) and histograms
- // ("TaskScheduler." + histogram name + "." + |name| + extra suffixes). The
- // pool will contain up to |max_threads|. |priority_hint| is the preferred
- // thread priority; the actual thread priority depends on shutdown state and
- // platform capabilities. |standby_thread_policy| indicates whether an idle
+ // Constructs a set of params used to initialize a pool. The pool will contain
+ // up to |max_threads|. |standby_thread_policy| indicates whether an idle
// thread should be kept alive on standby. |suggested_reclaim_time| sets a
// suggestion on when to reclaim idle threads. The pool is free to ignore this
// value for performance or correctness reasons. |backward_compatibility|
// indicates whether backward compatibility is enabled.
- //
- // TODO(fdoray): Remove this constructor. https://crbug.com/690706
- SchedulerWorkerPoolParams(
- const std::string& name,
- ThreadPriority priority_hint,
- StandbyThreadPolicy standby_thread_policy,
- int max_threads,
- TimeDelta suggested_reclaim_time,
- SchedulerBackwardCompatibility backward_compatibility =
- SchedulerBackwardCompatibility::DISABLED);
-
- // Same as above, with no explicit |name| and |priority_hint|.
SchedulerWorkerPoolParams(
StandbyThreadPolicy standby_thread_policy,
int max_threads,
@@ -55,8 +36,6 @@ class BASE_EXPORT SchedulerWorkerPoolParams final {
SchedulerWorkerPoolParams(const SchedulerWorkerPoolParams& other);
SchedulerWorkerPoolParams& operator=(const SchedulerWorkerPoolParams& other);
- const std::string& name() const { return name_; }
- ThreadPriority priority_hint() const { return priority_hint_; }
StandbyThreadPolicy standby_thread_policy() const {
return standby_thread_policy_;
}
@@ -67,9 +46,6 @@ class BASE_EXPORT SchedulerWorkerPoolParams final {
}
private:
- // TODO(fdoray): Remove |name_| and |priority_hint_|. https://crbug.com/690706
- std::string name_;
- ThreadPriority priority_hint_;
StandbyThreadPolicy standby_thread_policy_;
int max_threads_;
TimeDelta suggested_reclaim_time_;
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl_unittest.cc ('k') | base/task_scheduler/scheduler_worker_pool_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698