Issue 2835543002: start merging fasta.precedence into analyzer.TokenType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2835543002: start merging fasta.precedence into analyzer.TokenType (Closed)

Created:
3 years, 8 months ago by danrubel

Modified:
3 years, 6 months ago

Reviewers:
ahe, Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

start merging fasta.precedence into analyzer.TokenType * move methods and fields from PrecedenceInfo into TokenType * extract precedence consts R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/a76255249b5b1f463842b79a627045fc42fd27aa

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -144 lines)			Patch
	M	pkg/front_end/lib/src/fasta/scanner/precedence.dart	View		10 chunks	+78 lines, -113 lines	0 comments	Download
	M	pkg/front_end/lib/src/scanner/token.dart	View		4 chunks	+58 lines, -31 lines	0 comments	Download

Total messages: 6 (2 generated)

danrubel

Committed patchset #2 (id:20001) manually as a76255249b5b1f463842b79a627045fc42fd27aa (presubmit successful).

3 years, 8 months ago (2017-04-23 13:09:03 UTC) #5

Message was sent while issue was closed.

lgtm