Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2434)

Unified Diff: chrome/browser/sync/test/integration/sync_test.h

Issue 2835503003: Replace SyncTest::SetUpInProcessBrowserTestFixture with SyncTest::SetUpOnMainThread. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/sync_test.h
diff --git a/chrome/browser/sync/test/integration/sync_test.h b/chrome/browser/sync/test/integration/sync_test.h
index ba2b818c59d416d86ad1a149e140f8c8f67fd478..313ccd37d577bb77513324a47489b56b333fd707 100644
--- a/chrome/browser/sync/test/integration/sync_test.h
+++ b/chrome/browser/sync/test/integration/sync_test.h
@@ -18,7 +18,6 @@
#include "components/sync/protocol/sync_protocol_error.h"
#include "components/sync/test/fake_server/fake_server.h"
#include "components/sync/test/local_sync_test_server.h"
-#include "net/dns/mock_host_resolver.h"
#include "net/http/http_status_code.h"
#include "net/url_request/url_request_status.h"
@@ -62,7 +61,6 @@ class FakeServerInvalidationService;
namespace net {
class FakeURLFetcherFactory;
-class ScopedDefaultHostResolverProc;
class URLFetcherImplFactory;
} // namespace net
@@ -264,18 +262,10 @@ class SyncTest : public InProcessBrowserTest {
// on by default yet.
virtual void AddOptionalTypesToCommandLine(base::CommandLine* cl);
- // BrowserTestBase override. Destroys all the sync clients and sync
- // profiles created by a test.
+ // BrowserTestBase implementation:
+ void SetUpOnMainThread() override;
void TearDownOnMainThread() override;
- // InProcessBrowserTest override. Changes behavior of the default host
- // resolver to avoid DNS lookup errors.
- void SetUpInProcessBrowserTestFixture() override;
-
- // InProcessBrowserTest override. Resets the host resolver its default
- // behavior.
- void TearDownInProcessBrowserTestFixture() override;
-
// Implementations of the EnableNotifications() and DisableNotifications()
// functions defined above.
void DisableNotificationsImpl();
@@ -456,12 +446,6 @@ class SyncTest : public InProcessBrowserTest {
// creation via http requests.
bool create_gaia_account_at_runtime_;
- // Sync integration tests need to make live DNS requests for access to
- // GAIA and sync server URLs under google.com. We use a scoped version
- // to override the default resolver while the test is active.
- std::unique_ptr<net::ScopedDefaultHostResolverProc>
- mock_host_resolver_override_;
-
// Used to start and stop the local test server.
base::Process test_server_;
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/sync_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698