Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2835483003: Remove "changed main thread scrolling reasons" as a reason for scroll nodes. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
index 09c25f88501dfaaccb70aa53b710247eaaa7ce0a..2e972ab9b6ea04132c69352a6c00af5979f89f04 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
@@ -879,14 +879,11 @@ void PaintPropertyTreeBuilder::UpdateScrollAndScrollTranslation(
auto ancestor_reasons =
context.current.scroll->GetMainThreadScrollingReasons();
auto reasons = GetMainThreadScrollingReasons(object, ancestor_reasons);
- bool scroll_node_needed_for_main_thread_reasons =
- ancestor_reasons != reasons;
const LayoutBox& box = ToLayoutBox(object);
auto* scrollable_area = box.GetScrollableArea();
IntSize scroll_offset = box.ScrolledContentOffset();
- if (scroll_node_needed_for_main_thread_reasons ||
- !scroll_offset.IsZero() || scrollable_area->ScrollsOverflow()) {
+ if (!scroll_offset.IsZero() || scrollable_area->ScrollsOverflow()) {
needs_scroll_properties = true;
auto& properties =
object.GetMutableForPainting().EnsurePaintProperties();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698