Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 2835453002: Parametrize over the additional agrument type for StatementVisitor1 and ExpressionVisitor1 (Closed)

Created:
3 years, 8 months ago by zhivkag
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Parametrize over the additional agrument type for StatementVisitor1 and ExpressionVisitor1 BUG= R=dmitryas@google.com Committed: https://github.com/dart-lang/sdk/commit/b00a85231e3926a983113801d6c19005cb0bfdca

Patch Set 1 #

Total comments: 2

Patch Set 2 : Apply comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -104 lines) Patch
M pkg/kernel/lib/interpreter/interpreter.dart View 1 11 chunks +44 lines, -35 lines 0 comments Download
M pkg/kernel/lib/visitor.dart View 1 chunk +71 lines, -69 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zhivkag
3 years, 8 months ago (2017-04-20 14:20:07 UTC) #2
Dmitry Stefantsov
LGTM with one comment https://codereview.chromium.org/2835453002/diff/1/pkg/kernel/lib/interpreter/interpreter.dart File pkg/kernel/lib/interpreter/interpreter.dart (right): https://codereview.chromium.org/2835453002/diff/1/pkg/kernel/lib/interpreter/interpreter.dart#newcode115 pkg/kernel/lib/interpreter/interpreter.dart:115: Configuration visitStaticGet(StaticGet node, state) => ...
3 years, 8 months ago (2017-04-20 15:48:15 UTC) #3
zhivkag
Thanks! https://codereview.chromium.org/2835453002/diff/1/pkg/kernel/lib/interpreter/interpreter.dart File pkg/kernel/lib/interpreter/interpreter.dart (right): https://codereview.chromium.org/2835453002/diff/1/pkg/kernel/lib/interpreter/interpreter.dart#newcode115 pkg/kernel/lib/interpreter/interpreter.dart:115: Configuration visitStaticGet(StaticGet node, state) => On 2017/04/20 15:48:15, ...
3 years, 8 months ago (2017-04-20 16:02:53 UTC) #4
zhivkag
3 years, 8 months ago (2017-04-20 16:03:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b00a85231e3926a983113801d6c19005cb0bfdca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698