Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2835413002: chromeos: Add CHROMEOS_EXPORT to CPUTemperatureReader (Closed)

Created:
3 years, 8 months ago by Simon Que
Modified:
3 years, 8 months ago
Reviewers:
stevenjb, Daniel Erat
CC:
chromium-reviews, oshima+watch_chromium.org, Patrick Monette, pkalinnikov, alancutter1, hcarmona
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Add CHROMEOS_EXPORT to CPUTemperatureReader It built successfully in non-component builds but failed to link in the component build. BUG=chromium:709102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chromeos/system/cpu_temperature_reader.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Simon Que
3 years, 8 months ago (2017-04-25 02:47:10 UTC) #2
Daniel Erat
lgtm
3 years, 8 months ago (2017-04-25 03:37:16 UTC) #3
stevenjb
3 years, 8 months ago (2017-04-25 16:56:52 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698