Properly handle implicit closure function when a generic function.

runtime/vm/flow_graph_compiler_x64.cc

Index: runtime/vm/flow_graph_compiler_x64.cc
diff --git a/runtime/vm/flow_graph_compiler_x64.cc b/runtime/vm/flow_graph_compiler_x64.cc
index 13af4ded99552b80b93ba4ba10646a6ddfd83bdc..59fed95ea7312340dd1259c15a917b0dc765381a 100644
--- a/runtime/vm/flow_graph_compiler_x64.cc
+++ b/runtime/vm/flow_graph_compiler_x64.cc
@@ -1089,6 +1089,16 @@ void FlowGraphCompiler::CompileGraph() {
     }
   }
 
+  if (FLAG_reify_generic_functions) {
+    // TODO(regis): Check function type arguments of a generic function.
+    // For now, verify that a local variable has been allocated when necessary.
+    ASSERT((function.NumTypeParameters() == 0) ||
+           (parsed_function().function_type_arguments() != NULL));
+    // TODO(regis): Allocate and prepend parent type arguments when necessary.
+    ASSERT(!function.HasGenericParent() ||
+           (parsed_function().parent_type_arguments() != NULL));
+  }

[siva, 2017/04/25 21:58:06]

Should this assert also happen on other architectures?

[regis, 2017/04/25 22:08:33]

I should probably not have committed these asserts, especially since
FLAG_reify_generic_functions is false by default and not working yet. They help
me verify my work in progress and are only temporary. Having them on x64 only is
good enough for now. Sorry for the sloppiness.

[siva, 2017/04/25 22:31:32]

Sounds good, no need to add to other targets yet, was just wondering about it.

+
   EndCodeSourceRange(TokenPosition::kDartCodePrologue);
   ASSERT(!block_order().is_empty());
   VisitBlocks();