Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner.cc

Issue 2835253002: Treat already existing saved pages as success. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/background_loader_offliner.cc
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.cc b/chrome/browser/android/offline_pages/background_loader_offliner.cc
index 3ff7ad6e177676c6b2319a9e80513ae8ad16b41f..15a47cf8d910923128aa6ed85fd4e14c85b1dc97 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner.cc
+++ b/chrome/browser/android/offline_pages/background_loader_offliner.cc
@@ -364,7 +364,8 @@ void BackgroundLoaderOffliner::OnPageSaved(SavePageResult save_result,
save_state_ = NONE;
Offliner::RequestStatus save_status;
- if (save_result == SavePageResult::SUCCESS) {
+ if (save_result == SavePageResult::SUCCESS ||
+ save_result == SavePageResult::ALREADY_EXISTS) {
fgorski 2017/04/24 19:51:51 Hey, 3 questions: 1. Did you check if we maybe rem
Pete Williamson 2017/04/25 00:09:00 We don't remove it, because we then get the same e
if (did_snapshot_on_last_retry)
save_status = RequestStatus::SAVED_ON_LAST_RETRY;
else
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698