Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: extensions/browser/guest_view/web_view/web_view_apitest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)
Patch Set: ready for review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/guest_view/app_view/app_view_apitest.cc ('k') | extensions/shell/test/shell_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/web_view/web_view_apitest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_apitest.cc b/extensions/browser/guest_view/web_view/web_view_apitest.cc
index 6206dd126d5f9b38f92ff6ede01423ffca341007..aef32e9ebe832fdc8ffd9c1d2bb9370aa7c82bd7 100644
--- a/extensions/browser/guest_view/web_view/web_view_apitest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_apitest.cc
@@ -11,6 +11,7 @@
#include "base/path_service.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
+#include "base/threading/thread_restrictions.h"
#include "build/build_config.h"
#include "components/guest_view/browser/guest_view_manager.h"
#include "components/guest_view/browser/guest_view_manager_delegate.h"
@@ -138,6 +139,7 @@ WebViewAPITest::WebViewAPITest() {
}
void WebViewAPITest::LaunchApp(const std::string& app_location) {
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
base::FilePath test_data_dir;
PathService::Get(DIR_TEST_DATA, &test_data_dir);
test_data_dir = test_data_dir.AppendASCII(app_location.c_str());
@@ -203,6 +205,7 @@ void WebViewAPITest::StartTestServer(const std::string& app_location) {
test_config_.SetInteger(kTestServerPort, embedded_test_server()->port());
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
base::FilePath test_data_dir;
PathService::Get(DIR_TEST_DATA, &test_data_dir);
test_data_dir = test_data_dir.AppendASCII(app_location.c_str());
« no previous file with comments | « extensions/browser/guest_view/app_view/app_view_apitest.cc ('k') | extensions/shell/test/shell_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698