Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Unified Diff: extensions/browser/api/printer_provider/printer_provider_apitest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)
Patch Set: ready for review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/printer_provider/printer_provider_apitest.cc
diff --git a/extensions/browser/api/printer_provider/printer_provider_apitest.cc b/extensions/browser/api/printer_provider/printer_provider_apitest.cc
index d0b8cb40f6525e72bbaece0d03aa4d5ad209cec4..b53ac1001c75880aa70865740365784c13879f83 100644
--- a/extensions/browser/api/printer_provider/printer_provider_apitest.cc
+++ b/extensions/browser/api/printer_provider/printer_provider_apitest.cc
@@ -18,6 +18,7 @@
#include "base/run_loop.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/threading/thread_restrictions.h"
#include "device/usb/mock_usb_device.h"
#include "device/usb/mock_usb_service.h"
#include "extensions/browser/api/printer_provider/printer_provider_api.h"
@@ -99,7 +100,10 @@ class PrinterProviderApiTest : public ShellApiTest {
};
PrinterProviderApiTest() {}
- ~PrinterProviderApiTest() override {}
+ ~PrinterProviderApiTest() override {
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
+ ignore_result(data_dir_.Delete());
+ }
void StartGetPrintersRequest(
const PrinterProviderAPI::GetPrintersCallback& callback) {
@@ -238,10 +242,12 @@ class PrinterProviderApiTest : public ShellApiTest {
case PRINT_REQUEST_DATA_TYPE_FILE:
ASSERT_TRUE(StartPrintRequestUsingFileInfo(extension_id, callback));
break;
- case PRINT_REQUEST_DATA_TYPE_FILE_DELETED:
+ case PRINT_REQUEST_DATA_TYPE_FILE_DELETED: {
ASSERT_TRUE(StartPrintRequestUsingFileInfo(extension_id, callback));
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
ASSERT_TRUE(data_dir_.Delete());
break;
+ }
case PRINT_REQUEST_DATA_TYPE_BYTES:
StartPrintRequestUsingDocumentBytes(extension_id, callback);
break;
@@ -349,6 +355,7 @@ class PrinterProviderApiTest : public ShellApiTest {
int size,
base::FilePath* path,
base::File::Info* file_info) {
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
if (!data_dir_.IsValid() && !data_dir_.CreateUniqueTempDir())
return false;
« no previous file with comments | « content/public/test/browser_test_base.cc ('k') | extensions/browser/guest_view/app_view/app_view_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698