Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: chrome/test/remoting/qunit_browser_test_runner.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)
Patch Set: ready for review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/ppapi/ppapi_test.cc ('k') | components/autofill/core/browser/data_driven_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/remoting/qunit_browser_test_runner.cc
diff --git a/chrome/test/remoting/qunit_browser_test_runner.cc b/chrome/test/remoting/qunit_browser_test_runner.cc
index c309649ee15defa6fe8e4d4f259e556d3621bced..b84a30a198d5b4fcba49c48bb058031cd6f0a399 100644
--- a/chrome/test/remoting/qunit_browser_test_runner.cc
+++ b/chrome/test/remoting/qunit_browser_test_runner.cc
@@ -6,6 +6,7 @@
#include "base/files/file_util.h"
#include "base/json/json_reader.h"
+#include "base/threading/thread_restrictions.h"
#include "base/values.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ -39,8 +40,11 @@ void QUnitBrowserTestRunner::QUnitStart(content::WebContents* web_contents) {
}
void QUnitBrowserTestRunner::RunTest(const base::FilePath& file) {
- ASSERT_TRUE(PathExists(file)) << "Error: The QUnit test suite <"
- << file.value() << "> does not exist.";
+ {
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
+ ASSERT_TRUE(PathExists(file)) << "Error: The QUnit test suite <"
+ << file.value() << "> does not exist.";
+ }
ui_test_utils::NavigateToURL(browser(), net::FilePathToFileURL(file));
content::WebContents* web_contents =
« no previous file with comments | « chrome/test/ppapi/ppapi_test.cc ('k') | components/autofill/core/browser/data_driven_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698