chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc - Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)

Patch Set: ready for review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc ('k') | chrome/browser/ui/webui/policy_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

index b9b21f5e54d7e2ff3c8df678602dd0c111013cdf..f0ce3fa556ad30e5072985a5bc60f68858cb3168 100644

--- a/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

@@ -16,6 +16,7 @@

#include "base/strings/string_split.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

+#include "base/threading/thread_restrictions.h"

#include "base/values.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/io_thread.h"

@@ -290,6 +291,7 @@ void NetInternalsTest::MessageHandler::CloseIncognitoBrowser(

void NetInternalsTest::MessageHandler::GetNetLogFileContents(

const base::ListValue* list_value) {

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

base::ScopedTempDir temp_directory;

ASSERT_TRUE(temp_directory.CreateUniqueTempDir());

base::FilePath temp_file;