Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3484)

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)
Patch Set: ready for review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
diff --git a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
index 1a1b9ffd8818de1d596c9996a0a26f6f746aab2c..d7294633cc0c105ac4582a6f7d043a70bb1b8212 100644
--- a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
+++ b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
@@ -435,7 +435,10 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindLongString) {
base::FilePath().AppendASCII("find_in_page"),
base::FilePath().AppendASCII("LongFind.txt"));
std::string query;
- base::ReadFileToString(path, &query);
+ {
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
+ base::ReadFileToString(path, &query);
+ }
EXPECT_EQ(1, FindInPage16(web_contents, base::UTF8ToUTF16(query),
kFwd, kIgnoreCase, NULL));
}
@@ -501,7 +504,10 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindWholeFileContent) {
ui_test_utils::NavigateToURL(browser(), net::FilePathToFileURL(path));
std::string query;
- base::ReadFileToString(path, &query);
+ {
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
+ base::ReadFileToString(path, &query);
+ }
EXPECT_EQ(1, FindInPage16(web_contents, base::UTF8ToUTF16(query),
false, false, NULL));
}

Powered by Google App Engine
This is Rietveld 408576698