Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: chrome/browser/sync/test/integration/bookmarks_helper.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)
Patch Set: ready for review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/bookmarks_helper.cc
diff --git a/chrome/browser/sync/test/integration/bookmarks_helper.cc b/chrome/browser/sync/test/integration/bookmarks_helper.cc
index da2ab1c139a709a3cc71509beb0699a577dbb0ad..cfc07f82ad061c3beceaf24be74b1cef8752e481 100644
--- a/chrome/browser/sync/test/integration/bookmarks_helper.cc
+++ b/chrome/browser/sync/test/integration/bookmarks_helper.cc
@@ -24,6 +24,7 @@
#include "base/strings/utf_string_conversions.h"
#include "base/synchronization/waitable_event.h"
#include "base/task/cancelable_task_tracker.h"
+#include "base/threading/thread_restrictions.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/bookmarks/managed_bookmark_service_factory.h"
#include "chrome/browser/favicon/favicon_service_factory.h"
@@ -852,6 +853,7 @@ gfx::Image CreateFavicon(SkColor color) {
}
gfx::Image Create1xFaviconFromPNGFile(const std::string& path) {
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
const char* kPNGExtension = ".png";
if (!base::EndsWith(path, kPNGExtension,
base::CompareCase::INSENSITIVE_ASCII))
« no previous file with comments | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | chrome/browser/sync/test/integration/single_client_directory_sync_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698