Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)
Patch Set: ready for review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
index ab5ca80da4348a89bc77424290bfcc1f1d0548e9..03e93a4798fa1d8d8ed0bd848711717e9845f463 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
@@ -1504,6 +1504,7 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, StartAndStop) {
EXPECT_TRUE(csd_service->enabled());
// Add a new Profile. SBS should keep running.
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
ASSERT_TRUE(temp_profile_dir_.CreateUniqueTempDir());
std::unique_ptr<Profile> profile2(Profile::CreateProfile(
temp_profile_dir_.GetPath(), nullptr, Profile::CREATE_MODE_SYNCHRONOUS));
@@ -1603,7 +1604,10 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceShutdownTest,
// Create an additional profile. We need to use the ProfileManager so that
// the profile will get destroyed in the normal browser shutdown process.
ProfileManager* profile_manager = g_browser_process->profile_manager();
- ASSERT_TRUE(temp_profile_dir_.CreateUniqueTempDir());
+ {
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
+ ASSERT_TRUE(temp_profile_dir_.CreateUniqueTempDir());
+ }
profile_manager->CreateProfileAsync(
temp_profile_dir_.GetPath(),
base::Bind(&SafeBrowsingServiceShutdownTest::OnUnblockOnProfileCreation,

Powered by Google App Engine
This is Rietveld 408576698