Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4684)

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)
Patch Set: ready for review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/crx_installer_browsertest.cc
diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc
index af7b9e43094af44b85ddf37d6fb70441bee034db..9e32e0d757e8fe815423f81f7f4390f1340eba76 100644
--- a/chrome/browser/extensions/crx_installer_browsertest.cc
+++ b/chrome/browser/extensions/crx_installer_browsertest.cc
@@ -14,6 +14,7 @@
#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/threading/thread_restrictions.h"
#include "build/build_config.h"
#include "chrome/browser/download/download_crx_util.h"
#include "chrome/browser/extensions/browser_action_test_util.h"
@@ -214,6 +215,7 @@ class ExtensionCrxInstallerTest : public ExtensionBrowserTest {
bool strict_manifest_checks) {
std::unique_ptr<WebstoreInstaller::Approval> result;
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
base::FilePath ext_path = test_data_dir_.AppendASCII(manifest_dir);
std::string error;
std::unique_ptr<base::DictionaryValue> parsed_manifest(
@@ -338,6 +340,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTestWithExperimentalApis,
IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, BlockedFileTypes) {
const Extension* extension =
InstallExtension(test_data_dir_.AppendASCII("blocked_file_types.crx"), 1);
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
EXPECT_TRUE(base::PathExists(extension->path().AppendASCII("test.html")));
EXPECT_TRUE(base::PathExists(extension->path().AppendASCII("test.nexe")));
EXPECT_FALSE(base::PathExists(extension->path().AppendASCII("test1.EXE")));
@@ -349,6 +352,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, AllowedThemeFileTypes) {
test_data_dir_.AppendASCII("theme_with_extension.crx"), 1);
ASSERT_TRUE(extension);
const base::FilePath& path = extension->path();
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
EXPECT_TRUE(
base::PathExists(path.AppendASCII("images/theme_frame_camo.PNG")));
EXPECT_TRUE(
@@ -599,6 +603,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, InstallToSharedLocation) {
crx_path, 1, extensions::Manifest::EXTERNAL_PREF);
base::FilePath extension_path = extension->path();
EXPECT_TRUE(cache_dir.GetPath().IsParent(extension_path));
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
EXPECT_TRUE(base::PathExists(extension_path));
std::string extension_id = extension->id();
« no previous file with comments | « chrome/browser/extensions/content_verifier_browsertest.cc ('k') | chrome/browser/extensions/extension_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698