Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5694)

Unified Diff: chrome/browser/extensions/api/page_capture/page_capture_apitest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)
Patch Set: ready for review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/page_capture/page_capture_apitest.cc
diff --git a/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc b/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc
index 3cdf16b7efa0f2f87e112f420aa44ff1bd0f2804..035b46242d7a81c73cb21ce3b4678e3a8a5be20e 100644
--- a/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc
+++ b/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc
@@ -4,6 +4,7 @@
#include "base/base_switches.h"
#include "base/command_line.h"
+#include "base/threading/thread_restrictions.h"
#include "chrome/browser/extensions/api/page_capture/page_capture_api.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/common/chrome_switches.h"
@@ -54,6 +55,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionPageCaptureApiTest, SaveAsMHTML) {
content::RunAllPendingInMessageLoop(content::BrowserThread::IO);
// Make sure the temporary file is destroyed once the javascript side reads
// the contents.
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
ASSERT_FALSE(base::PathExists(delegate.temp_file_));
}
@@ -73,6 +75,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionPageCaptureApiTest,
ASSERT_FALSE(delegate.temp_file_.empty());
content::RunAllPendingInMessageLoop(content::BrowserThread::FILE);
content::RunAllPendingInMessageLoop(content::BrowserThread::IO);
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
ASSERT_FALSE(base::PathExists(delegate.temp_file_));
}

Powered by Google App Engine
This is Rietveld 408576698