Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)
Patch Set: ready for review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
diff --git a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
index 2d57dda866e562ffd42d7201213406c8be3b8c72..5250c1e77cf231954f3ef5b7c953e0d25e962005 100644
--- a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
+++ b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
@@ -8,6 +8,7 @@
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/macros.h"
+#include "base/threading/thread_restrictions.h"
#include "build/build_config.h"
#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
#include "chrome/browser/extensions/browser_action_test_util.h"
@@ -71,6 +72,7 @@ void ExecuteExtensionAction(Browser* browser, const Extension* extension) {
std::unique_ptr<base::ScopedTempDir> CreateAndSetDownloadsDirectory(
PrefService* pref_service) {
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
std::unique_ptr<base::ScopedTempDir> dir(new base::ScopedTempDir);
if (!dir->CreateUniqueTempDir())
@@ -1012,6 +1014,7 @@ IN_PROC_BROWSER_TEST_F(NavigatingExtensionPopupBrowserTest, DownloadViaPost) {
// Override the default downloads directory, so that the test can cleanup
// after itself. This section is based on CreateAndSetDownloadsDirectory
// method defined in a few other source files with tests.
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
std::unique_ptr<base::ScopedTempDir> downloads_directory =
CreateAndSetDownloadsDirectory(browser()->profile()->GetPrefs());
ASSERT_TRUE(downloads_directory);

Powered by Google App Engine
This is Rietveld 408576698