chrome/browser/extensions/api/commands/command_service_browsertest.cc - Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/commands/command_service_browsertest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)

Patch Set: ready for review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/commands/command_service_browsertest.cc

diff --git a/chrome/browser/extensions/api/commands/command_service_browsertest.cc b/chrome/browser/extensions/api/commands/command_service_browsertest.cc

index 636cffe6ef499552a9df64de22f56817b21fdd32..cfd932f931ddaff691b0b3ccf40c88b3740666d2 100644

--- a/chrome/browser/extensions/api/commands/command_service_browsertest.cc

+++ b/chrome/browser/extensions/api/commands/command_service_browsertest.cc

@@ -5,6 +5,7 @@

#include <utility>

#include "base/memory/ptr_util.h"

+#include "base/threading/thread_restrictions.h"

#include "base/values.h"

#include "build/build_config.h"

#include "chrome/browser/extensions/api/commands/command_service.h"

@@ -45,6 +46,7 @@ namespace extensions {

typedef ExtensionApiTest CommandServiceTest;

IN_PROC_BROWSER_TEST_F(CommandServiceTest, RemoveShortcutSurvivesUpdate) {

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

base::ScopedTempDir scoped_temp_dir;

EXPECT_TRUE(scoped_temp_dir.CreateUniqueTempDir());

base::FilePath pem_path = test_data_dir_.