Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

chrome/test/ppapi/ppapi_filechooser_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
+#include "base/threading/thread_restrictions.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/ppapi/ppapi_test.h"
 #include "content/public/common/quarantine.h"
 #include "ppapi/shared_impl/test_utils.h"
 #include "ui/shell_dialogs/select_file_dialog.h"
 #include "ui/shell_dialogs/select_file_dialog_factory.h"
 #include "ui/shell_dialogs/selected_file_info.h"
 
 #if defined(FULL_SAFE_BROWSING)
@@ skipping 239 matching lines @@
  private:
   TestSafeBrowsingServiceFactory safe_browsing_service_factory_;
 };
 
 #endif
 
 }  // namespace
 
 IN_PROC_BROWSER_TEST_F(PPAPIFileChooserTest, FileChooser_Open_Success) {
   const char kContents[] = "Hello from browser";
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
 
   base::FilePath existing_filename = temp_dir.GetPath().AppendASCII("foo");
   ASSERT_EQ(
       static_cast<int>(sizeof(kContents) - 1),
       base::WriteFile(existing_filename, kContents, sizeof(kContents) - 1));
 
   TestSelectFileDialogFactory::SelectedFileInfoList file_info_list;
   file_info_list.push_back(
       ui::SelectedFileInfo(existing_filename, existing_filename));
   TestSelectFileDialogFactory test_dialog_factory(
       TestSelectFileDialogFactory::RESPOND_WITH_FILE_LIST, file_info_list);
   RunTestViaHTTP("FileChooser_OpenSimple");
 }
 
 IN_PROC_BROWSER_TEST_F(PPAPIFileChooserTest, FileChooser_Open_Cancel) {
   TestSelectFileDialogFactory test_dialog_factory(
       TestSelectFileDialogFactory::CANCEL,
       TestSelectFileDialogFactory::SelectedFileInfoList());
   RunTestViaHTTP("FileChooser_OpenCancel");
 }
 
 IN_PROC_BROWSER_TEST_F(PPAPIFileChooserTest, FileChooser_SaveAs_Success) {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   base::FilePath suggested_filename = temp_dir.GetPath().AppendASCII("foo");
 
   TestSelectFileDialogFactory::SelectedFileInfoList file_info_list;
   file_info_list.push_back(
       ui::SelectedFileInfo(suggested_filename, suggested_filename));
   TestSelectFileDialogFactory test_dialog_factory(
       TestSelectFileDialogFactory::RESPOND_WITH_FILE_LIST, file_info_list);
 
   RunTestViaHTTP("FileChooser_SaveAsSafeDefaultName");
   ASSERT_TRUE(base::PathExists(suggested_filename));
 }
 
 IN_PROC_BROWSER_TEST_F(PPAPIFileChooserTest,
                        FileChooser_SaveAs_SafeDefaultName) {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   base::FilePath suggested_filename = temp_dir.GetPath().AppendASCII("foo");
 
   TestSelectFileDialogFactory::SelectedFileInfoList file_info_list;
   file_info_list.push_back(
       ui::SelectedFileInfo(suggested_filename, suggested_filename));
   TestSelectFileDialogFactory test_dialog_factory(
       TestSelectFileDialogFactory::REPLACE_BASENAME, file_info_list);
 
   RunTestViaHTTP("FileChooser_SaveAsSafeDefaultName");
   base::FilePath actual_filename =
       temp_dir.GetPath().AppendASCII("innocuous.txt");
 
   ASSERT_TRUE(base::PathExists(actual_filename));
   std::string file_contents;
   ASSERT_TRUE(base::ReadFileToString(actual_filename, &file_contents));
   EXPECT_EQ("Hello from PPAPI", file_contents);
 }
 
 IN_PROC_BROWSER_TEST_F(PPAPIFileChooserTest,
                        FileChooser_SaveAs_UnsafeDefaultName) {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   base::FilePath suggested_filename = temp_dir.GetPath().AppendASCII("foo");
 
   TestSelectFileDialogFactory::SelectedFileInfoList file_info_list;
   file_info_list.push_back(
       ui::SelectedFileInfo(suggested_filename, suggested_filename));
   TestSelectFileDialogFactory test_dialog_factory(
       TestSelectFileDialogFactory::REPLACE_BASENAME, file_info_list);
 
@@ skipping 14 matching lines @@
   RunTestViaHTTP("FileChooser_SaveAsCancel");
 }
 
 #if defined(OS_WIN) || defined(OS_LINUX)
 // On Windows, tests that a file downloaded via PPAPI FileChooser API has the
 // mark-of-the-web. The PPAPI FileChooser implementation invokes QuarantineFile
 // in order to mark the file as being downloaded from the web as soon as the
 // file is created. This MOTW prevents the file being opened without due
 // security warnings if the file is executable.
 IN_PROC_BROWSER_TEST_F(PPAPIFileChooserTest, FileChooser_Quarantine) {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   base::FilePath suggested_filename = temp_dir.GetPath().AppendASCII("foo");
 
   TestSelectFileDialogFactory::SelectedFileInfoList file_info_list;
   file_info_list.push_back(
       ui::SelectedFileInfo(suggested_filename, suggested_filename));
   TestSelectFileDialogFactory test_dialog_factory(
       TestSelectFileDialogFactory::REPLACE_BASENAME, file_info_list);
 
   RunTestViaHTTP("FileChooser_SaveAsDangerousExecutableAllowed");
   base::FilePath actual_filename =
       temp_dir.GetPath().AppendASCII("dangerous.exe");
 
   ASSERT_TRUE(base::PathExists(actual_filename));
   EXPECT_TRUE(content::IsFileQuarantined(actual_filename, GURL(), GURL()));
 }
 #endif  // defined(OS_WIN) || defined(OS_LINUX)
 
 #if defined(FULL_SAFE_BROWSING)
 // These tests only make sense when SafeBrowsing is enabled. They verify
 // that files written via the FileChooser_Trusted API are properly passed
 // through Safe Browsing.
 
 IN_PROC_BROWSER_TEST_F(PPAPIFileChooserTestWithSBService,
                        FileChooser_SaveAs_DangerousExecutable_Allowed) {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   safe_browsing_test_configuration_.default_result =
       DownloadProtectionService::DANGEROUS;
   safe_browsing_test_configuration_.result_map.insert(
       std::make_pair(base::FilePath::StringType(FILE_PATH_LITERAL(".exe")),
                      DownloadProtectionService::SAFE));
 
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   base::FilePath suggested_filename = temp_dir.GetPath().AppendASCII("foo");
 
@@ skipping 35 matching lines @@
       std::make_pair(base::FilePath::StringType(FILE_PATH_LITERAL(".exe")),
                      DownloadProtectionService::DANGEROUS));
 
   TestSelectFileDialogFactory test_dialog_factory(
       TestSelectFileDialogFactory::NOT_REACHED,
       TestSelectFileDialogFactory::SelectedFileInfoList());
   RunTestViaHTTP("FileChooser_SaveAsDangerousExtensionListDisallowed");
 }
 
 #endif  // FULL_SAFE_BROWSING