Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view_browsertest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)
Patch Set: ready for review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/threading/thread_restrictions.h"
5 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 6 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
6 #include "chrome/browser/signin/fake_signin_manager_builder.h" 7 #include "chrome/browser/signin/fake_signin_manager_builder.h"
7 #include "chrome/browser/signin/signin_manager_factory.h" 8 #include "chrome/browser/signin/signin_manager_factory.h"
8 #include "chrome/browser/ui/test/test_browser_dialog.h" 9 #include "chrome/browser/ui/test/test_browser_dialog.h"
9 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h" 10 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
10 #include "chrome/browser/ui/views/frame/browser_view.h" 11 #include "chrome/browser/ui/views/frame/browser_view.h"
11 #include "chrome/browser/ui/views/location_bar/star_view.h" 12 #include "chrome/browser/ui/views/location_bar/star_view.h"
12 #include "chrome/browser/ui/views/toolbar/toolbar_view.h" 13 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
13 #include "chrome/test/base/browser_with_test_window_test.h" 14 #include "chrome/test/base/browser_with_test_window_test.h"
14 #include "components/bookmarks/browser/bookmark_utils.h" 15 #include "components/bookmarks/browser/bookmark_utils.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 } 76 }
76 } 77 }
77 78
78 private: 79 private:
79 std::unique_ptr<TestingProfile> profile_; 80 std::unique_ptr<TestingProfile> profile_;
80 DISALLOW_COPY_AND_ASSIGN(BookmarkBubbleViewBrowserTest); 81 DISALLOW_COPY_AND_ASSIGN(BookmarkBubbleViewBrowserTest);
81 }; 82 };
82 83
83 IN_PROC_BROWSER_TEST_F(BookmarkBubbleViewBrowserTest, 84 IN_PROC_BROWSER_TEST_F(BookmarkBubbleViewBrowserTest,
84 InvokeDialog_bookmark_details) { 85 InvokeDialog_bookmark_details) {
86 base::ThreadRestrictions::ScopedAllowIO allow_io;
85 RunDialog(); 87 RunDialog();
86 } 88 }
87 89
88 IN_PROC_BROWSER_TEST_F(BookmarkBubbleViewBrowserTest, 90 IN_PROC_BROWSER_TEST_F(BookmarkBubbleViewBrowserTest,
89 InvokeDialog_bookmark_details_signed_in) { 91 InvokeDialog_bookmark_details_signed_in) {
92 base::ThreadRestrictions::ScopedAllowIO allow_io;
90 RunDialog(); 93 RunDialog();
91 } 94 }
92 95
93 #if defined(OS_WIN) 96 #if defined(OS_WIN)
94 IN_PROC_BROWSER_TEST_F(BookmarkBubbleViewBrowserTest, 97 IN_PROC_BROWSER_TEST_F(BookmarkBubbleViewBrowserTest,
95 InvokeDialog_ios_promotion) { 98 InvokeDialog_ios_promotion) {
99 base::ThreadRestrictions::ScopedAllowIO allow_io;
96 RunDialog(); 100 RunDialog();
97 } 101 }
98 #endif 102 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698